Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[text-area]: readOnly prop not listed as part of StencilCalciteTextArea interface #11217

Closed
2 of 6 tasks
LanceStasinski opened this issue Jan 7, 2025 · 2 comments
Closed
2 of 6 tasks

[text-area]: readOnly prop not listed as part of StencilCalciteTextArea interface #11217

LanceStasinski opened this issue Jan 7, 2025 · 2 comments
Assignees
@DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2025-01-30 - 3.0....

Comments

@LanceStasinski
Copy link

Check existing issues

Actual Behavior

The readOnly property is listed in the doc for calcite-text-area, but the property is not listed as part of the StencilCalciteTextArea interface. This causes TS errors in stencil JSX.

Expected Behavior

The readOnly property should be listed as part of the StencilCalciteTextArea interface.

Reproduction Sample

NA

Reproduction Steps

Add readOnly to a <calcite-text-area> element in stencil JSX. Notice the TS error.

Type '{ readOnly: true; }' is not assignable to type 'StencilCalciteTextArea'.
  Property 'readOnly' does not exist on type 'StencilCalciteTextArea'.

Reproduction Version

3.0.0-next.89

Relevant Info

No response

Regression?

Last version of 2.x

Priority impact

impact - p1 - need for current milestone

Impact

This breaks stencil builds when readOnly is added to a calcite-text-area.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Field Apps
@LanceStasinski LanceStasinski added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Jan 7, 2025
@github-actions github-actions bot added ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Jan 7, 2025
@jcfranco jcfranco self-assigned this Jan 7, 2025
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. p - high Issue should be addressed in the current milestone, impacts component or core functionality and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 7, 2025
@jcfranco jcfranco added the estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. label Jan 7, 2025
@jcfranco jcfranco mentioned this issue Jan 7, 2025
Merged
jcfranco added a commit that referenced this issue Jan 7, 2025
@jcfranco
fix(text-area): make readOnly prop writable (#11218)
0cbf766 
**Related Issue:** #11217 #10731

## Summary

Removes unintentional `@readonly` on `readOnly` prop. 

For context, with #10310 any props with the `@readonly` tag will be made
read-only.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jan 8, 2025
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Jan 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Installed and assigned for verification.

@geospatialem geospatialem removed their assignment Jan 9, 2025
@DitwanP
Copy link
Contributor

DitwanP commented Jan 10, 2025

Verified on 3.0.0-next.94

@DitwanP DitwanP closed this as completed Jan 10, 2025
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2025-01-30 - 3.0.0 Jan Breaking Chang...
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @LanceStasinski @DitwanP