refactor(loadable): deprecate obsolete helpers #11312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
refactor
jcfranco
added
the
pr ready for visual snapshots
jcfranco
requested review from
driskull and
benelan
and removed request for
driskull
driskull
approved these changes
Jan 17, 2025
5 tasks
github-actions
bot
added this to the 2025-01-30 - 3.0.0 Jan Breaking Change Release milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #11305
Summary
This deprecates loadable helpers to allow for incremental migration. After #10310,
componentOnReadyis available for both lazy and non-lazy-loading outputs, so we can replace our custom utils that previously worked around Stencil’s inconsistency.