-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typeclass - record - create SemigroupUnion, MonoidUnion and SemigroupIntersection #2635
typeclass - record - create SemigroupUnion, MonoidUnion and SemigroupIntersection #2635
Conversation
🦋 Changeset detectedLatest commit: 13b45d33ba41bba5570ff940444bbe3543f142be The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest adding a get
prefix to align it with the current convention, for example, getSemigroupUnion
.
I wonder how useful an instance for ReadonlyRecord<string | symbol, A>
is. Generally, it's much more common to work with ReadonlyRecord<string, A>
. Furthermore, the current implementation does not work with records with symbolic keys (Record.union
only works with keys of type string).
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Tim <hello@timsmart.co>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
#3508) Co-authored-by: Maxwell Brown <maxwellbrown1990@gmail.com>
Co-authored-by: Tim <hello@timsmart.co>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Tim <hello@timsmart.co>
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
Co-authored-by: Tim <hello@timsmart.co>
Co-authored-by: Tim <hello@timsmart.co>
Co-authored-by: Tim Smart <tim.smart@arisechurch.com>
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz> Co-authored-by: Tim <hello@timsmart.co>
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz> Co-authored-by: Tim <hello@timsmart.co>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
…#3826) Co-authored-by: Tim <hello@timsmart.co>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
25d6918
to
13b45d3
Compare
Type
Description
Creates
SemigroupUnion
,MonoidUnion
andSemigroupIntersection
forRecord
I didn't create anything for
difference
as I didn't see the pointI didn't ceate a
Monoid
forintersection
as I can't think of a logical empty element (I could do it with some kind of Proxy maybe ?)Related