Add getSemigroupUnion, getMonoidUnion and getSemigroupIntersection for Record #3840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8fb2d08 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
it's fine, it doesn't exist |
gcanti
approved these changes
Oct 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
Creates
getSemigroupUnion,getMonoidUnionandgetSemigroupIntersectionforRecordI didn't create anything for
differenceas I didn't see the pointI didn't ceate a
Monoidforintersectionas I can't think of a logical empty element (I could do it with some kind of Proxy maybe ?)Note: I already created a PR similar to this one a loooooong time ago but I messed up the git history so I just recreated a new PR altogether. @gcanti already left some comments that I took into consideration in this new PR. The previous PR was this one: #2635 (don't try to look at the files it makes Github melt)
Related