Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getSemigroupUnion, getMonoidUnion and getSemigroupIntersection for Record #3840

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/large-laws-drum.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@effect/typeclass": patch
---

Add getSemigroupUnion, getMonoidUnion and getSemigroupIntersection for Record
58 changes: 58 additions & 0 deletions packages/typeclass/src/data/Record.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import type * as applicative from "../Applicative.js"
import * as covariant from "../Covariant.js"
import type * as filterable from "../Filterable.js"
import type * as invariant from "../Invariant.js"
import * as monoid from "../Monoid.js"
import * as semigroup from "../Semigroup.js"
import type * as traversable from "../Traversable.js"
import type * as traversableFilterable from "../TraversableFilterable.js"

Expand Down Expand Up @@ -201,3 +203,59 @@ export const getTraversableFilterable = <K extends string>(): traversableFiltera
* @since 0.24.0
*/
export const TraversableFilterable = getTraversableFilterable()

/**
* A `Semigroup` that creates an union of two records.
*
* @example
* import * as NumberInstances from "@effect/typeclass/data/Number"
* import { getSemigroupUnion } from "@effect/typeclass/data/Record"
*
* assert.deepStrictEqual(getSemigroupUnion(NumberInstances.MonoidSum).combine({ a: 1 }, { a: 1, b: 3 }), { a: 2, b: 3 })
*
* @category instances
* @since 0.29.3
*/
export const getSemigroupUnion: <A>(
value: semigroup.Semigroup<A>
) => semigroup.Semigroup<Record.ReadonlyRecord<string, A>> = <A>(value: semigroup.Semigroup<A>) =>
semigroup.make<Record<string, A>>((self, that) => Record.union(self, that, value.combine))

/**
* A `Monoid` that creates an union of two records.
*
* The `empty` value is `{}`.
*
* @example
* import * as NumberInstances from "@effect/typeclass/data/Number"
* import { getMonoidUnion } from "@effect/typeclass/data/Record"
*
* const monoid = getMonoidUnion(NumberInstances.MonoidSum)
*
* assert.deepStrictEqual(monoid.combine({ a: 1 }, { a: 1, b: 3 }), { a: 2, b: 3 })
* assert.deepStrictEqual(monoid.combine({ a: 1 }, monoid.empty), { a: 1 })
*
* @category instances
* @since 0.29.3
*/
export const getMonoidUnion: <A>(
value: monoid.Monoid<A>
) => monoid.Monoid<Record.ReadonlyRecord<string, A>> = <A>(value: monoid.Monoid<A>) =>
monoid.fromSemigroup(getSemigroupUnion<A>(value), Record.empty<string, A>())

/**
* A `Semigroup` that creates an intersection of two records.
*
* @example
* import * as NumberInstances from "@effect/typeclass/data/Number"
* import { getSemigroupIntersection } from "@effect/typeclass/data/Record"
*
* assert.deepStrictEqual(getSemigroupIntersection(NumberInstances.MonoidSum).combine({ a: 1 }, { a: 1, b: 3 }), { a: 2 })
*
* @category instances
* @since 0.29.3
*/
export const getSemigroupIntersection: <A>(
value: semigroup.Semigroup<A>
) => semigroup.Semigroup<Record.ReadonlyRecord<string, A>> = <A>(value: semigroup.Semigroup<A>) =>
semigroup.make<Record<string, A>>((self, that) => Record.intersection(self, that, value.combine))
41 changes: 41 additions & 0 deletions packages/typeclass/test/data/Record.test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
import * as NumberInstances from "@effect/typeclass/data/Number"
import * as OptionInstances from "@effect/typeclass/data/Option"
import * as RecordInstances from "@effect/typeclass/data/Record"
import * as monoid from "@effect/typeclass/Monoid"
import * as semigroup from "@effect/typeclass/Semigroup"
import * as Option from "effect/Option"
import { describe, expect, it } from "vitest"

Expand Down Expand Up @@ -40,4 +43,42 @@ describe.concurrent("Record", () => {
}
expect(traverse(symbolRecord, (a) => Option.some(a))).toStrictEqual(Option.some({}))
})

it("SemigroupUnion", () => {
const semigroupUnion = RecordInstances.getSemigroupUnion(semigroup.struct({
inner: NumberInstances.SemigroupSum
}))

const a = { a: { inner: 1 } }
const b = { a: { inner: 3 }, b: { inner: 2 } }
const c = { b: { inner: 7 } }
expect(semigroupUnion.combine(a, b)).toStrictEqual({ a: { inner: 4 }, b: { inner: 2 } })
expect(semigroupUnion.combineMany(a, [b, c])).toStrictEqual({ a: { inner: 4 }, b: { inner: 9 } })
})

it("MonoidUnion", () => {
const monoidUnion = RecordInstances.getMonoidUnion(monoid.struct({
inner: NumberInstances.MonoidMax
}))

const a = { a: { inner: 1 } }
const b = { a: { inner: 3 }, b: { inner: 2 } }
const c = { b: { inner: 7 } }
expect(monoidUnion.combine(a, b)).toStrictEqual({ a: { inner: 3 }, b: { inner: 2 } })
expect(monoidUnion.combine(a, monoidUnion.empty)).toStrictEqual(a)
expect(monoidUnion.combineMany(a, [b, c])).toStrictEqual({ a: { inner: 3 }, b: { inner: 7 } })
expect(monoidUnion.combineAll([a, b, c])).toStrictEqual({ a: { inner: 3 }, b: { inner: 7 } })
})

it("SemigroupIntersection", () => {
const semigroupIntersection = RecordInstances.getSemigroupIntersection(semigroup.struct({
inner: NumberInstances.SemigroupSum
}))

const a = { a: { inner: 1 } }
const b = { a: { inner: 3 }, b: { inner: 2 } }
const c = { b: { inner: 7 } }
expect(semigroupIntersection.combine(a, b)).toStrictEqual({ a: { inner: 4 } })
expect(semigroupIntersection.combineMany(a, [b, c])).toStrictEqual({})
})
})