Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Config constructor : Config.stringNonEmpty #3514

Merged
merged 5 commits into from
Aug 30, 2024

Conversation

titouancreach
Copy link
Contributor

@titouancreach titouancreach commented Aug 29, 2024

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Added a new constructor to config.

Related

Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: 8f0cad3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
effect Minor
@effect/cli Major
@effect/cluster-browser Major
@effect/cluster-node Major
@effect/cluster-workflow Major
@effect/cluster Major
@effect/experimental Major
@effect/opentelemetry Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc-http Major
@effect/rpc Major
@effect/schema Major
@effect/sql-d1 Major
@effect/sql-drizzle Major
@effect/sql-kysely Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/typeclass Major
@effect/vitest Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot changed the base branch from main to next-minor August 29, 2024 10:12
packages/effect/src/Config.ts Outdated Show resolved Hide resolved
packages/effect/src/internal/config.ts Outdated Show resolved Hide resolved
@titouancreach titouancreach changed the title Add a Config constructor : Config.nonEmptyString Add a Config constructor : Config. stringNonEmpty Aug 30, 2024
@titouancreach titouancreach changed the title Add a Config constructor : Config. stringNonEmpty Add a Config constructor : Config.stringNonEmpty Aug 30, 2024
@titouancreach
Copy link
Contributor Author

Thanks for the review ! I updated the PR accordingly

@tim-smart tim-smart merged commit de32b32 into Effect-TS:next-minor Aug 30, 2024
11 checks passed
@github-actions github-actions bot mentioned this pull request Aug 30, 2024
@titouancreach titouancreach deleted the nonemptyconfig branch August 30, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants