Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preserve Array.replace Array.replaceOption non emptiness #3491

Merged
merged 3 commits into from
Aug 22, 2024
Merged

preserve Array.replace Array.replaceOption non emptiness #3491

merged 3 commits into from
Aug 22, 2024

Conversation

KhraksMamtsov
Copy link
Contributor

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Related

  • Related Issue #
  • Closes #

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: d1c2f63

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
effect Minor
@effect/cli Major
@effect/cluster-browser Major
@effect/cluster-node Major
@effect/cluster-workflow Major
@effect/cluster Major
@effect/experimental Major
@effect/opentelemetry Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc-http Major
@effect/rpc Major
@effect/schema Major
@effect/sql-d1 Major
@effect/sql-drizzle Major
@effect/sql-kysely Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/typeclass Major
@effect/vitest Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot force-pushed the next-minor branch 2 times, most recently from 6c5d26a to aacbb7a Compare August 20, 2024 22:10
tim-smart
tim-smart reviewed Aug 20, 2024
View reviewed changes
Copy link
Member

@tim-smart tim-smart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Could you add some dtslint tests?

@github-actions github-actions bot force-pushed the next-minor branch 2 times, most recently from 2234d76 to 7d264aa Compare August 21, 2024 00:47
@gcanti gcanti merged commit baca8b6 into Effect-TS:next-minor Aug 22, 2024
11 checks passed
@github-actions github-actions bot mentioned this pull request Aug 22, 2024
Merged
@vinassefranche vinassefranche mentioned this pull request Aug 22, 2024
Merged
5 tasks
dilame pushed a commit to dilame/effect that referenced this pull request Aug 22, 2024
@KhraksMamtsov @dilame
preserve Array.replace Array.replaceOption non emptiness (Effect-…
9f80364 
…TS#3491)

Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
github-actions bot pushed a commit that referenced this pull request Aug 23, 2024
@KhraksMamtsov @tim-smart
preserve Array.replace Array.replaceOption non emptiness (#3491)
73dc641 
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
github-actions bot pushed a commit that referenced this pull request Aug 23, 2024
@KhraksMamtsov @tim-smart
preserve Array.replace Array.replaceOption non emptiness (#3491)
7ba0d87 
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
github-actions bot pushed a commit that referenced this pull request Aug 26, 2024
@KhraksMamtsov @tim-smart
preserve Array.replace Array.replaceOption non emptiness (#3491)
1cad1f2 
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
github-actions bot pushed a commit that referenced this pull request Aug 27, 2024
@KhraksMamtsov @tim-smart
preserve Array.replace Array.replaceOption non emptiness (#3491)
a49e68b 
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
github-actions bot pushed a commit that referenced this pull request Aug 27, 2024
@KhraksMamtsov @tim-smart
preserve Array.replace Array.replaceOption non emptiness (#3491)
3c96775 
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
github-actions bot pushed a commit that referenced this pull request Aug 27, 2024
@KhraksMamtsov @tim-smart
preserve Array.replace Array.replaceOption non emptiness (#3491)
5786176 
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
github-actions bot pushed a commit that referenced this pull request Aug 29, 2024
@KhraksMamtsov @IMax153
preserve Array.replace Array.replaceOption non emptiness (#3491)
cce0dc1 
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
github-actions bot pushed a commit that referenced this pull request Aug 29, 2024
@KhraksMamtsov @tim-smart
preserve Array.replace Array.replaceOption non emptiness (#3491)
032dd10 
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
github-actions bot pushed a commit that referenced this pull request Aug 30, 2024
@KhraksMamtsov @tim-smart
preserve Array.replace Array.replaceOption non emptiness (#3491)
207022e 
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
tim-smart pushed a commit that referenced this pull request Aug 30, 2024
@KhraksMamtsov @tim-smart
preserve Array.replace Array.replaceOption non emptiness (#3491)
d6e7e40 
Co-authored-by: maksim.khramtsov <maksim.khramtsov@btsdigital.kz>
@KhraksMamtsov KhraksMamtsov deleted the array-replace branch September 25, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-smart tim-smart tim-smart left review comments

@gcanti gcanti gcanti left review comments

@mikearnaldi mikearnaldi Awaiting requested review from mikearnaldi mikearnaldi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KhraksMamtsov @tim-smart @gcanti