v4.49.0 proposal #4848
Draft
v4.49.0 proposal #4848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 7.86 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.2.1 | 19.18 MB | 19.19 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 7.01 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| - run: yarn test:llmobs:sdk:ci | ||
| - if: always() | ||
| uses: ./.github/actions/testagent/logs | ||
| - uses: codecov/codecov-action@v3 |
There was a problem hiding this comment.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
| env: | ||
| PLUGINS: openai | ||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
BenchmarksBenchmark execution time: 2024-10-31 23:47:37 Comparing candidate commit 6354c06 in PR branch Found 3 performance improvements and 2 performance regressions! Performance is the same for 766 metrics, 27 unstable metrics. scenario:plugin-graphql-with-depth-and-collapse-on-16
scenario:plugin-graphql-with-depth-off-16
scenario:plugin-graphql-with-depth-off-18
scenario:plugin-graphql-with-depth-on-max-16
scenario:plugin-graphql-with-depth-on-max-18
|
* Handle request options * Remove .only * clean up * suggestion
…' tag (#4724) Use existing 'otel' tag for other sources of spans, such as manual tracing
* fix esbuild issue when requiring esm files
* standardize configurations
It was out-of-date since the following commit was added to master, which updated package.json without also updating yarn.lock: 597d7c5
The maxCollectionSize limit affects the following types: - Array - Map / WeakMap - Set / WeakSet - All TypedArray types This limit contols the maximum about of elements collected for those types. The default is 100.
* refactor system tests jobs to no longer explicitly try to run `CROSSED_TRACING_LIBRARIES` scenarios, which is now an essential scenario and was being run twice.
* add support for DD_GRPC_CLIENT_ERROR_STATUSES & DD_GRPC_SERVER_ERROR_STATUSES
* Use @datadog/pprof 5.4.1 with Node 23 support
* separating plugin tests to their own run
Adds Kafka cluster ID to KafkaJS spans and DSM metrics
…sibility (#4821) * Apply suggestions from code review Co-authored-by: Nikita Tkachenko <121111529+nikita-tkachenko-datadog@users.noreply.github.com>
…ce (#4739) * Allow to set sampling priority * Span.keep method * Replace manual.keep tag usage with Span.keep() * Update standalone integration tests * use PrioritySampler.keepTrace * Lint * PrioritySampler.keepTrace test
The limit controls the maximum number of properties collected on an object. The default is 20. It's also applied on each scope when collecting properties. If there's for example more than maxFieldCount properties in the current scope, they are not all collected.
* multer instrumentation * clean up test * unsubscribe multer * multer CI tests * multer CI plugins tests * Change multer version range * Specify the version * second try * third * multer request blocking integration test * include iast tainting multer body test * fix test * Update integration-tests/multer.spec.js Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com> * Move taint multipart body test to the integration test * delete test * Move multer tests inside appsec * Include test not using multer middleware --------- Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com>
* [MLOB-1540] add llmobs configuration to global tracer config (#4696) add llmobs config * [MLOB-1555] LLM Observability writers (#4699) LLM Observability writers * [MLOB-1556] LLM Observability tagger (#4718) LLM Observability tagger * [MLOB-1560] LLMObs Span Processor (#4738) * span processor * tests * remove agent exporter log and do not stringify tags * remove llmobs from exporter tests * add in default unserializable value * review comments * warning log for metric * todo-ify * remove some duplicate logic * decouple llmobs span processing with a channel * use a static weakmap to store llmobs tags/annotations instead of span tags * do not register span in map if it does not have an llmobs span kind * span is passed on an object from sp publisher * re-clarify TODOs * only send span in publish * log multiple warnings and return conditional undefined * update error logic * [MLOB-1561] LLM Observability SDK API (#4773) * wip * type definitions * active + try/catch eval metric writer append * test ts * use tagger map and processor as a channel subscriber * change decorate and add in dev changes * try some api changes * add decorate to noop * fix breaking proxy tests * experimental decorators for TS docs * api changes, fix unit + e2e tests * try removing global log mocks * add some util tests * remove logger mocks * add module tests + do not enable when not specified * fix eval metric integration test * wip * memoize getFunctionArguments * move any subscriber and global writer to the module enablement level instead of sdk * should fix TS tests * add ts integration test and fix decorator * devex for ts versions * add noop typescript test * remove startSpan * remove unneeded change * dedup decorator code * Update index.d.ts Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com> * map metrics names * change validKind to validateKind and throw * tagger for metrics follow-up * review feedback * add some tests for not auto-annotating in certain cases --------- Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com> * hard fail instead of soft fail, except for `wrap` span name * add ml-observability codeowners * resolve ts test * update auto-annotation check * tagger can soft fail * using custom ASL instance and scope activation * fix test comments and remove * address review comments * remove llmobs.apiKey config, only rely on global * fix evaulations test * make llmobs storage accessible --------- Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com>
The log track has a 1MB limit of the JSON payload. The client is not notified if the payload is too large, but it is simply never indexed. This is a very crude approach. In the future a more sophsticated algorithm will be implemented that reduces the size of the snapshot instead of removing it completely.
* add dsm for google pub sub
* implementation * try making llmobs base plugin a normal plugin * add codeowners change * add yarn services to test:llmobs:ci * try gh action llmobs changes * Update packages/dd-trace/src/llmobs/plugins/base.js * proper finish time for openai spans * move * revert finish changes * change llmobsplugin back to tracingplugin type * rename function for clarity
* upgrade to latest @azure/functions version
rochdev
force-pushed
the
v4.49.0-proposal
branch
from
0d44bd6
to
6354c06
Compare
| PLUGINS: mariadb | ||
| SERVICES: mariadb | ||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
| - uses: ./.github/actions/node/latest | ||
| - run: yarn test:llmobs:plugins:ci | ||
| shell: bash | ||
| - uses: codecov/codecov-action@v3 |
There was a problem hiding this comment.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.