Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dsm for google pub sub #3855

Merged
merged 7 commits into from
Oct 30, 2024
Merged

Conversation

wconti27
Copy link
Contributor

@wconti27 wconti27 commented Dec 8, 2023

What does this PR do?

Adds DSM propagation for Google pub/sub AIT-9156

AIDM-411

Motivation

Adding DSM to relevant integrations

Plugin Checklist

Additional Notes

Security

Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@wconti27 wconti27 self-assigned this Dec 8, 2023
@wconti27 wconti27 requested a review from jbertran December 8, 2023 18:20
Copy link

github-actions bot commented Dec 8, 2023

Overall package size

Self size: 7.65 MB
Deduped: 64.51 MB
No deduping: 64.85 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.2.1 | 19.18 MB | 19.19 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.87%. Comparing base (fd0f570) to head (e5761a1).
Report is 28 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3855       +/-   ##
===========================================
+ Coverage   68.58%   88.87%   +20.29%     
===========================================
  Files          12      128      +116     
  Lines         818     4405     +3587     
===========================================
+ Hits          561     3915     +3354     
- Misses        257      490      +233     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Dec 8, 2023

Benchmarks

Benchmark execution time: 2024-10-29 17:36:29

Comparing candidate commit b976a78 in PR branch conti/add-dsm-for-google-pub-sub with baseline commit a081659 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics.

@wconti27 wconti27 removed the request for review from jbertran October 25, 2024 17:06
@wconti27 wconti27 marked this pull request as ready for review October 25, 2024 17:06
@wconti27 wconti27 requested review from a team as code owners October 25, 2024 17:06
piochelepiotr
piochelepiotr previously approved these changes Oct 25, 2024
@wconti27 wconti27 merged commit 9e65a80 into master Oct 30, 2024
204 checks passed
@wconti27 wconti27 deleted the conti/add-dsm-for-google-pub-sub branch October 30, 2024 14:09
rochdev pushed a commit that referenced this pull request Oct 31, 2024
* add dsm for google pub sub
rochdev pushed a commit that referenced this pull request Oct 31, 2024
* add dsm for google pub sub
rochdev pushed a commit that referenced this pull request Oct 31, 2024
* add dsm for google pub sub
rochdev pushed a commit that referenced this pull request Nov 6, 2024
* add dsm for google pub sub
rochdev pushed a commit that referenced this pull request Nov 6, 2024
* add dsm for google pub sub
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants