Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test visibility] Add dynamic instrumentation logs writer for test visibility #4821

Merged
merged 9 commits into from
Oct 28, 2024

Conversation

juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Oct 24, 2024

What does this PR do?

  • Add DynamicInstrumentationLogsWriter

ℹ️ This integration is behind the feature flag DD_TEST_DYNAMIC_INSTRUMENTATION_ENABLED

Motivation

We are in the process of releasing an integration between Dynamic Instrumentation and Test Visibility. This is the first step.

Test Visibility needs to support both agentless and agentful setups, so we need a writer that can report to both. The format is JSON.

Plugin Checklist

  • Unit tests.

Copy link

github-actions bot commented Oct 24, 2024

Overall package size

Self size: 7.62 MB
Deduped: 64.48 MB
No deduping: 64.82 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.2.1 | 19.18 MB | 19.19 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@juan-fernandez juan-fernandez marked this pull request as ready for review October 25, 2024 08:22
@juan-fernandez juan-fernandez requested review from a team as code owners October 25, 2024 08:22
tonyredondo
tonyredondo previously approved these changes Oct 28, 2024
Copy link
Member

@tonyredondo tonyredondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any test for the actual log json format we have to follow?

@juan-fernandez
Copy link
Collaborator Author

Do you have any test for the actual log json format we have to follow?

that's probably good to have. I'll add it

Co-authored-by: Nikita Tkachenko <121111529+nikita-tkachenko-datadog@users.noreply.github.com>
@pr-commenter
Copy link

pr-commenter bot commented Oct 28, 2024

Benchmarks

Benchmark execution time: 2024-10-28 10:43:24

Comparing candidate commit 879f771 in PR branch juan-fernandez/add-debugger-logs-writer with baseline commit aff335d in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics.

@juan-fernandez
Copy link
Collaborator Author

Do you have any test for the actual log json format we have to follow?

added it in 879f771

@juan-fernandez juan-fernandez merged commit 564795f into master Oct 28, 2024
204 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/add-debugger-logs-writer branch October 28, 2024 14:09
rochdev pushed a commit that referenced this pull request Oct 31, 2024
…sibility (#4821)

* Apply suggestions from code review

Co-authored-by: Nikita Tkachenko <121111529+nikita-tkachenko-datadog@users.noreply.github.com>
rochdev pushed a commit that referenced this pull request Oct 31, 2024
…sibility (#4821)

* Apply suggestions from code review

Co-authored-by: Nikita Tkachenko <121111529+nikita-tkachenko-datadog@users.noreply.github.com>
rochdev pushed a commit that referenced this pull request Oct 31, 2024
…sibility (#4821)

* Apply suggestions from code review

Co-authored-by: Nikita Tkachenko <121111529+nikita-tkachenko-datadog@users.noreply.github.com>
rochdev pushed a commit that referenced this pull request Nov 6, 2024
…sibility (#4821)

* Apply suggestions from code review

Co-authored-by: Nikita Tkachenko <121111529+nikita-tkachenko-datadog@users.noreply.github.com>
rochdev pushed a commit that referenced this pull request Nov 6, 2024
…sibility (#4821)

* Apply suggestions from code review

Co-authored-by: Nikita Tkachenko <121111529+nikita-tkachenko-datadog@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants