[DI] Adhere to maxFieldCount limit in snapshots #4829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Overall package sizeSelf size: 7.61 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.2.1 | 19.18 MB | 19.19 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
The limit controls the maximum number of properties collected on an object. The default is 20. It's also applied on each scope when collecting properties. If there's for example more than maxFieldCount properties in the current scope, they are not all collected.
watson
force-pushed
the
watson/DEBUG-2612/max-field-count
branch
from
495475d to
004359c
Compare
BenchmarksBenchmark execution time: 2024-10-28 13:01:55 Comparing candidate commit 004359c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 261 metrics, 5 unstable metrics. |
juan-fernandez
approved these changes
Oct 28, 2024
rochdev
pushed a commit
that referenced
this pull request
Oct 31, 2024
The limit controls the maximum number of properties collected on an object. The default is 20. It's also applied on each scope when collecting properties. If there's for example more than maxFieldCount properties in the current scope, they are not all collected.
rochdev
pushed a commit
that referenced
this pull request
Oct 31, 2024
The limit controls the maximum number of properties collected on an object. The default is 20. It's also applied on each scope when collecting properties. If there's for example more than maxFieldCount properties in the current scope, they are not all collected.
rochdev
pushed a commit
that referenced
this pull request
Oct 31, 2024
The limit controls the maximum number of properties collected on an object. The default is 20. It's also applied on each scope when collecting properties. If there's for example more than maxFieldCount properties in the current scope, they are not all collected.
rochdev
pushed a commit
that referenced
this pull request
Nov 6, 2024
The limit controls the maximum number of properties collected on an object. The default is 20. It's also applied on each scope when collecting properties. If there's for example more than maxFieldCount properties in the current scope, they are not all collected.
rochdev
pushed a commit
that referenced
this pull request
Nov 6, 2024
The limit controls the maximum number of properties collected on an object. The default is 20. It's also applied on each scope when collecting properties. If there's for example more than maxFieldCount properties in the current scope, they are not all collected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
maxFieldCountlimit in Dynamic Instrumentation (provided by the probe configuration via Remote Configuraiton).The limit controls the maximum number of properties collected on an object. The default is
20.It's also applied on each scope when collecting properties. If there's for example more than
maxFieldCountproperties in the current scope, they are not all collected.