Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make nav buttons larger and remove outline on back save and edit buttons #143

Merged
merged 7 commits into from
Sep 24, 2023
Merged

make nav buttons larger and remove outline on back save and edit buttons #143

merged 7 commits into from
Sep 24, 2023

Conversation

Penguine-Os
Copy link
Contributor

Closes #91

chrisK00
chrisK00 reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@chrisK00 chrisK00 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind posting a screenshot of the home page? - after the upcoming changes

@chrisK00
Copy link
Contributor

chrisK00 commented Sep 20, 2023 •
edited
Loading

About the nav buttons

  • Can we make the buttons close to each other again and centered so the user doesnt have to move their thumb to the other end of the screen
  • Add some space to the bottom of the buttons, its quite easy to missclick and click the androids back/home/open apps buttons.
  • Remove the -fill from the calendar icon so its consistent with the home button
  • Also add a tiny bit of space above the icons (the line above them is too close)
  • You can make the icons a tiny bit smaller
  • When you push the icons from the upper divider or from the bottom, use padding on the buttons so that they are easily clicked

@Penguine-Os
Copy link
Contributor Author

afbeelding

@chrisK00
Copy link
Contributor

afbeelding

Space above looks good on this img. Is this be4/after my comment

chrisK00
chrisK00 requested changes Sep 23, 2023
View reviewed changes
subtrack.MAUI/Shared/NavBar.razor Outdated Show resolved Hide resolved
subtrack.MAUI/Shared/NavBar.razor Outdated Show resolved Hide resolved
subtrack.MAUI/Shared/NavBar.razor Outdated Show resolved Hide resolved
subtrack.MAUI/Shared/NavBar.razor Outdated Show resolved Hide resolved
subtrack.MAUI/Shared/NavBar.razor Outdated Show resolved Hide resolved
subtrack.MAUI/Shared/NavBar.razor Outdated Show resolved Hide resolved
subtrack.MAUI/Shared/NavBar.razor Outdated Show resolved Hide resolved
subtrack.MAUI/Shared/NavBar.razor Outdated Show resolved Hide resolved
@chrisK00
Copy link
Contributor

qemu-system-x86_64_3cHNwuKScZ
After my suggested changes

@chrisK00
Copy link
Contributor

closes #134

@chrisK00 chrisK00 linked an issue Sep 24, 2023 that may be closed by this pull request
Details page change button's background to match the theme #134
Closed
@chrisK00 chrisK00 merged commit 31a9a85 into dev Sep 24, 2023
1 check passed
@chrisK00 chrisK00 deleted the feature/Make-nav-buttons-larger-and-remove-outline-on-back-save-and-edit-buttons branch September 24, 2023 10:08
chrisK00 added a commit that referenced this pull request Sep 24, 2023
@chrisK00 @kgrontis
@denislavh @ashwin003 @Penguine-Os
Release 2.1.0 (#146)
521799d 
* Update README.md

* Update README.md

* revert version

* revert comments

* companyname

* Update README.md

* #114 Implemented CssUtil.GetDueClass & tests (#123)

* #114 Implemented CssUtil.GetDueClass & tests

* #114 Added semicolor to css rule

* #114 Changed placement of css rule.

* #114 removed dots from string result.

* #114 PR review changes.

* #115 Added call to GetDueClass method in monthly page. (#124)

* add mockups for icons and colors

* Adds font color to due period depending on severity. (#126)

* Adds font color to due period depending on severity.

* Returns text-end class for Index page.

* Preserves newline in subscription description (#131)

* Introduces subscription background color. (#135)

* Adds background color to the database

* Adds a control to select background color for a subscription

* Updates tests to include background color

* Updates migration scripts

* Update subtrack.MAUI/Utilities/CssUtil.cs

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor updates

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor adjustments

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #128 make labels less visible (#136)

* #128 make labels less visible

* Update subtrack.MAUI/wwwroot/css/app.css

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #125 Added US Culture as a constant (#144)

* #142 Fixed descriptions not displayed correctly. (#145)

* update roadmap

* make nav buttons larger and remove outline on back save and edit buttons (#143)

* btn outline => btn filled

* navbar simplification

* resolve comments

* format and remove non existing css class

* remove default styling

---------

Co-authored-by: ChrisK00 <christian.khalil2000@gmail.com>
Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

---------

Co-authored-by: Konstantinos Grontis <grodiscostas@hotmail.com>
Co-authored-by: denislavh <53407843+denislavh@users.noreply.github.com>
Co-authored-by: Ashwin Thyagarajan <ashwin031192@gmail.com>
Co-authored-by: Penguine-Os <yenebeb.df@gmail.com>
chrisK00 added a commit that referenced this pull request Nov 1, 2023
@chrisK00 @kgrontis
@denislavh @ashwin003 @Penguine-Os
Release v2.2.0 (#153)
2c867da 
* Update README.md

* Update README.md

* revert version

* revert comments

* companyname

* Update README.md

* #114 Implemented CssUtil.GetDueClass & tests (#123)

* #114 Implemented CssUtil.GetDueClass & tests

* #114 Added semicolor to css rule

* #114 Changed placement of css rule.

* #114 removed dots from string result.

* #114 PR review changes.

* #115 Added call to GetDueClass method in monthly page. (#124)

* add mockups for icons and colors

* Adds font color to due period depending on severity. (#126)

* Adds font color to due period depending on severity.

* Returns text-end class for Index page.

* Preserves newline in subscription description (#131)

* Introduces subscription background color. (#135)

* Adds background color to the database

* Adds a control to select background color for a subscription

* Updates tests to include background color

* Updates migration scripts

* Update subtrack.MAUI/Utilities/CssUtil.cs

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor updates

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor adjustments

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #128 make labels less visible (#136)

* #128 make labels less visible

* Update subtrack.MAUI/wwwroot/css/app.css

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #125 Added US Culture as a constant (#144)

* #142 Fixed descriptions not displayed correctly. (#145)

* update roadmap

* make nav buttons larger and remove outline on back save and edit buttons (#143)

* btn outline => btn filled

* navbar simplification

* resolve comments

* format and remove non existing css class

* remove default styling

---------

Co-authored-by: ChrisK00 <christian.khalil2000@gmail.com>
Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Adds subscription icon and secondary color (#149)

* Adds database columns for icon and secondary color

* Adds controls for saving icon and secondary color for subscriptions

* Use subscription icon and secondary colors in the UI

* Updates migration scripts

* Minor updates to UI

* Minor UI updates

* Updates subscription details title

* Updates subscription details title

* fix flaky test

* Revert "fix flaky test"

This reverts commit b3bb61d.

* Feature/improve subscription card design poc (#150)

* fix create sub bug. New style for cards. use dot instead of comma

* fix overflow color picker input. fix currency on index showing on newline

* fix flaky test

* fix flaky test

* roadmap

---------

Co-authored-by: Konstantinos Grontis <grodiscostas@hotmail.com>
Co-authored-by: denislavh <53407843+denislavh@users.noreply.github.com>
Co-authored-by: Ashwin Thyagarajan <ashwin031192@gmail.com>
Co-authored-by: Penguine-Os <yenebeb.df@gmail.com>
chrisK00 added a commit that referenced this pull request Nov 5, 2023
@chrisK00 @kgrontis
@denislavh @ashwin003 @Penguine-Os
v2.2.1-alpha (#156)
a1a64dc 
* Update README.md

* Update README.md

* revert version

* revert comments

* companyname

* Update README.md

* #114 Implemented CssUtil.GetDueClass & tests (#123)

* #114 Implemented CssUtil.GetDueClass & tests

* #114 Added semicolor to css rule

* #114 Changed placement of css rule.

* #114 removed dots from string result.

* #114 PR review changes.

* #115 Added call to GetDueClass method in monthly page. (#124)

* add mockups for icons and colors

* Adds font color to due period depending on severity. (#126)

* Adds font color to due period depending on severity.

* Returns text-end class for Index page.

* Preserves newline in subscription description (#131)

* Introduces subscription background color. (#135)

* Adds background color to the database

* Adds a control to select background color for a subscription

* Updates tests to include background color

* Updates migration scripts

* Update subtrack.MAUI/Utilities/CssUtil.cs

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor updates

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor adjustments

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #128 make labels less visible (#136)

* #128 make labels less visible

* Update subtrack.MAUI/wwwroot/css/app.css

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #125 Added US Culture as a constant (#144)

* #142 Fixed descriptions not displayed correctly. (#145)

* update roadmap

* make nav buttons larger and remove outline on back save and edit buttons (#143)

* btn outline => btn filled

* navbar simplification

* resolve comments

* format and remove non existing css class

* remove default styling

---------

Co-authored-by: ChrisK00 <christian.khalil2000@gmail.com>
Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Adds subscription icon and secondary color (#149)

* Adds database columns for icon and secondary color

* Adds controls for saving icon and secondary color for subscriptions

* Use subscription icon and secondary colors in the UI

* Updates migration scripts

* Minor updates to UI

* Minor UI updates

* Updates subscription details title

* Updates subscription details title

* fix flaky test

* Revert "fix flaky test"

This reverts commit b3bb61d.

* Feature/improve subscription card design poc (#150)

* fix create sub bug. New style for cards. use dot instead of comma

* fix overflow color picker input. fix currency on index showing on newline

* fix flaky test

* fix flaky test

* roadmap

* order by year (#154)

* readme merge master

* fix

* return url on delete

---------

Co-authored-by: Konstantinos Grontis <grodiscostas@hotmail.com>
Co-authored-by: denislavh <53407843+denislavh@users.noreply.github.com>
Co-authored-by: Ashwin Thyagarajan <ashwin031192@gmail.com>
Co-authored-by: Penguine-Os <yenebeb.df@gmail.com>
chrisK00 added a commit that referenced this pull request Dec 11, 2023
@chrisK00 @kgrontis
@denislavh @ashwin003 @Penguine-Os
Release 2.3.1 (#164)
756c171 
* Update README.md

* Update README.md

* revert version

* revert comments

* companyname

* Update README.md

* #114 Implemented CssUtil.GetDueClass & tests (#123)

* #114 Implemented CssUtil.GetDueClass & tests

* #114 Added semicolor to css rule

* #114 Changed placement of css rule.

* #114 removed dots from string result.

* #114 PR review changes.

* #115 Added call to GetDueClass method in monthly page. (#124)

* add mockups for icons and colors

* Adds font color to due period depending on severity. (#126)

* Adds font color to due period depending on severity.

* Returns text-end class for Index page.

* Preserves newline in subscription description (#131)

* Introduces subscription background color. (#135)

* Adds background color to the database

* Adds a control to select background color for a subscription

* Updates tests to include background color

* Updates migration scripts

* Update subtrack.MAUI/Utilities/CssUtil.cs

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor updates

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor adjustments

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #128 make labels less visible (#136)

* #128 make labels less visible

* Update subtrack.MAUI/wwwroot/css/app.css

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #125 Added US Culture as a constant (#144)

* #142 Fixed descriptions not displayed correctly. (#145)

* update roadmap

* make nav buttons larger and remove outline on back save and edit buttons (#143)

* btn outline => btn filled

* navbar simplification

* resolve comments

* format and remove non existing css class

* remove default styling

---------

Co-authored-by: ChrisK00 <christian.khalil2000@gmail.com>
Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Adds subscription icon and secondary color (#149)

* Adds database columns for icon and secondary color

* Adds controls for saving icon and secondary color for subscriptions

* Use subscription icon and secondary colors in the UI

* Updates migration scripts

* Minor updates to UI

* Minor UI updates

* Updates subscription details title

* Updates subscription details title

* fix flaky test

* Revert "fix flaky test"

This reverts commit b3bb61d.

* Feature/improve subscription card design poc (#150)

* fix create sub bug. New style for cards. use dot instead of comma

* fix overflow color picker input. fix currency on index showing on newline

* fix flaky test

* fix flaky test

* roadmap

* order by year (#154)

* readme merge master

* fix

* return url on delete

* Update README.md

* Creates a settings page with controls for importing and exporting subscriptions (#157)

* Implement exporting subscriptions (#158)

* export subs

* update roadmap

* Update dotnet.yml

* do not target IOS

* Update dotnet.yml

* global.json

* more permissive .net 7 sdk

* #147 Changed status bar color for android. (#159)

* net 7 (#160)

* Implement Importing subscriptions (#161)

* added lastsubexporttime (#162)

* roadmap

---------

Co-authored-by: Konstantinos Grontis <grodiscostas@hotmail.com>
Co-authored-by: denislavh <53407843+denislavh@users.noreply.github.com>
Co-authored-by: Ashwin Thyagarajan <ashwin031192@gmail.com>
Co-authored-by: Penguine-Os <yenebeb.df@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisK00 chrisK00 chrisK00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Penguine-Os @chrisK00