Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds font color to due period depending on severity. #126

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

denislavh
Copy link
Contributor

I am not sure if the details page should have the font changed or the background. Closes #116.

@denislavh denislavh linked an issue Sep 11, 2023 that may be closed by this pull request
Copy link
Contributor

@chrisK00 chrisK00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to color the text inside the div so the current implementation is correct

subtrack.MAUI/Pages/Index.razor Outdated Show resolved Hide resolved
Copy link
Contributor

@chrisK00 chrisK00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gj!

@denislavh denislavh merged commit 6928bff into dev Sep 12, 2023
1 check passed
chrisK00 added a commit that referenced this pull request Sep 24, 2023
* Update README.md

* Update README.md

* revert version

* revert comments

* companyname

* Update README.md

* #114 Implemented CssUtil.GetDueClass & tests (#123)

* #114 Implemented CssUtil.GetDueClass & tests

* #114 Added semicolor to css rule

* #114 Changed placement of css rule.

* #114 removed dots from string result.

* #114 PR review changes.

* #115 Added call to GetDueClass method in monthly page. (#124)

* add mockups for icons and colors

* Adds font color to due period depending on severity. (#126)

* Adds font color to due period depending on severity.

* Returns text-end class for Index page.

* Preserves newline in subscription description (#131)

* Introduces subscription background color. (#135)

* Adds background color to the database

* Adds a control to select background color for a subscription

* Updates tests to include background color

* Updates migration scripts

* Update subtrack.MAUI/Utilities/CssUtil.cs

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor updates

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor adjustments

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #128 make labels less visible (#136)

* #128 make labels less visible

* Update subtrack.MAUI/wwwroot/css/app.css

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #125 Added US Culture as a constant (#144)

* #142 Fixed descriptions not displayed correctly. (#145)

* update roadmap

* make nav buttons larger and remove outline on back save and edit buttons (#143)

* btn outline => btn filled

* navbar simplification

* resolve comments

* format and remove non existing css class

* remove default styling

---------

Co-authored-by: ChrisK00 <christian.khalil2000@gmail.com>
Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

---------

Co-authored-by: Konstantinos Grontis <grodiscostas@hotmail.com>
Co-authored-by: denislavh <53407843+denislavh@users.noreply.github.com>
Co-authored-by: Ashwin Thyagarajan <ashwin031192@gmail.com>
Co-authored-by: Penguine-Os <yenebeb.df@gmail.com>
chrisK00 added a commit that referenced this pull request Nov 1, 2023
* Update README.md

* Update README.md

* revert version

* revert comments

* companyname

* Update README.md

* #114 Implemented CssUtil.GetDueClass & tests (#123)

* #114 Implemented CssUtil.GetDueClass & tests

* #114 Added semicolor to css rule

* #114 Changed placement of css rule.

* #114 removed dots from string result.

* #114 PR review changes.

* #115 Added call to GetDueClass method in monthly page. (#124)

* add mockups for icons and colors

* Adds font color to due period depending on severity. (#126)

* Adds font color to due period depending on severity.

* Returns text-end class for Index page.

* Preserves newline in subscription description (#131)

* Introduces subscription background color. (#135)

* Adds background color to the database

* Adds a control to select background color for a subscription

* Updates tests to include background color

* Updates migration scripts

* Update subtrack.MAUI/Utilities/CssUtil.cs

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor updates

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor adjustments

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #128 make labels less visible (#136)

* #128 make labels less visible

* Update subtrack.MAUI/wwwroot/css/app.css

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #125 Added US Culture as a constant (#144)

* #142 Fixed descriptions not displayed correctly. (#145)

* update roadmap

* make nav buttons larger and remove outline on back save and edit buttons (#143)

* btn outline => btn filled

* navbar simplification

* resolve comments

* format and remove non existing css class

* remove default styling

---------

Co-authored-by: ChrisK00 <christian.khalil2000@gmail.com>
Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Adds subscription icon and secondary color (#149)

* Adds database columns for icon and secondary color

* Adds controls for saving icon and secondary color for subscriptions

* Use subscription icon and secondary colors in the UI

* Updates migration scripts

* Minor updates to UI

* Minor UI updates

* Updates subscription details title

* Updates subscription details title

* fix flaky test

* Revert "fix flaky test"

This reverts commit b3bb61d.

* Feature/improve subscription card design poc (#150)

* fix create sub bug. New style for cards. use dot instead of comma

* fix overflow color picker input. fix currency on index showing on newline

* fix flaky test

* fix flaky test

* roadmap

---------

Co-authored-by: Konstantinos Grontis <grodiscostas@hotmail.com>
Co-authored-by: denislavh <53407843+denislavh@users.noreply.github.com>
Co-authored-by: Ashwin Thyagarajan <ashwin031192@gmail.com>
Co-authored-by: Penguine-Os <yenebeb.df@gmail.com>
chrisK00 added a commit that referenced this pull request Nov 5, 2023
* Update README.md

* Update README.md

* revert version

* revert comments

* companyname

* Update README.md

* #114 Implemented CssUtil.GetDueClass & tests (#123)

* #114 Implemented CssUtil.GetDueClass & tests

* #114 Added semicolor to css rule

* #114 Changed placement of css rule.

* #114 removed dots from string result.

* #114 PR review changes.

* #115 Added call to GetDueClass method in monthly page. (#124)

* add mockups for icons and colors

* Adds font color to due period depending on severity. (#126)

* Adds font color to due period depending on severity.

* Returns text-end class for Index page.

* Preserves newline in subscription description (#131)

* Introduces subscription background color. (#135)

* Adds background color to the database

* Adds a control to select background color for a subscription

* Updates tests to include background color

* Updates migration scripts

* Update subtrack.MAUI/Utilities/CssUtil.cs

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor updates

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor adjustments

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #128 make labels less visible (#136)

* #128 make labels less visible

* Update subtrack.MAUI/wwwroot/css/app.css

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #125 Added US Culture as a constant (#144)

* #142 Fixed descriptions not displayed correctly. (#145)

* update roadmap

* make nav buttons larger and remove outline on back save and edit buttons (#143)

* btn outline => btn filled

* navbar simplification

* resolve comments

* format and remove non existing css class

* remove default styling

---------

Co-authored-by: ChrisK00 <christian.khalil2000@gmail.com>
Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Adds subscription icon and secondary color (#149)

* Adds database columns for icon and secondary color

* Adds controls for saving icon and secondary color for subscriptions

* Use subscription icon and secondary colors in the UI

* Updates migration scripts

* Minor updates to UI

* Minor UI updates

* Updates subscription details title

* Updates subscription details title

* fix flaky test

* Revert "fix flaky test"

This reverts commit b3bb61d.

* Feature/improve subscription card design poc (#150)

* fix create sub bug. New style for cards. use dot instead of comma

* fix overflow color picker input. fix currency on index showing on newline

* fix flaky test

* fix flaky test

* roadmap

* order by year (#154)

* readme merge master

* fix

* return url on delete

---------

Co-authored-by: Konstantinos Grontis <grodiscostas@hotmail.com>
Co-authored-by: denislavh <53407843+denislavh@users.noreply.github.com>
Co-authored-by: Ashwin Thyagarajan <ashwin031192@gmail.com>
Co-authored-by: Penguine-Os <yenebeb.df@gmail.com>
chrisK00 added a commit that referenced this pull request Dec 11, 2023
* Update README.md

* Update README.md

* revert version

* revert comments

* companyname

* Update README.md

* #114 Implemented CssUtil.GetDueClass & tests (#123)

* #114 Implemented CssUtil.GetDueClass & tests

* #114 Added semicolor to css rule

* #114 Changed placement of css rule.

* #114 removed dots from string result.

* #114 PR review changes.

* #115 Added call to GetDueClass method in monthly page. (#124)

* add mockups for icons and colors

* Adds font color to due period depending on severity. (#126)

* Adds font color to due period depending on severity.

* Returns text-end class for Index page.

* Preserves newline in subscription description (#131)

* Introduces subscription background color. (#135)

* Adds background color to the database

* Adds a control to select background color for a subscription

* Updates tests to include background color

* Updates migration scripts

* Update subtrack.MAUI/Utilities/CssUtil.cs

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor updates

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor adjustments

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #128 make labels less visible (#136)

* #128 make labels less visible

* Update subtrack.MAUI/wwwroot/css/app.css

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #125 Added US Culture as a constant (#144)

* #142 Fixed descriptions not displayed correctly. (#145)

* update roadmap

* make nav buttons larger and remove outline on back save and edit buttons (#143)

* btn outline => btn filled

* navbar simplification

* resolve comments

* format and remove non existing css class

* remove default styling

---------

Co-authored-by: ChrisK00 <christian.khalil2000@gmail.com>
Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Adds subscription icon and secondary color (#149)

* Adds database columns for icon and secondary color

* Adds controls for saving icon and secondary color for subscriptions

* Use subscription icon and secondary colors in the UI

* Updates migration scripts

* Minor updates to UI

* Minor UI updates

* Updates subscription details title

* Updates subscription details title

* fix flaky test

* Revert "fix flaky test"

This reverts commit b3bb61d.

* Feature/improve subscription card design poc (#150)

* fix create sub bug. New style for cards. use dot instead of comma

* fix overflow color picker input. fix currency on index showing on newline

* fix flaky test

* fix flaky test

* roadmap

* order by year (#154)

* readme merge master

* fix

* return url on delete

* Update README.md

* Creates a settings page with controls for importing and exporting subscriptions (#157)

* Implement exporting subscriptions (#158)

* export subs

* update roadmap

* Update dotnet.yml

* do not target IOS

* Update dotnet.yml

* global.json

* more permissive .net 7 sdk

* #147 Changed status bar color for android. (#159)

* net 7 (#160)

* Implement Importing subscriptions (#161)

* added lastsubexporttime (#162)

* roadmap

---------

Co-authored-by: Konstantinos Grontis <grodiscostas@hotmail.com>
Co-authored-by: denislavh <53407843+denislavh@users.noreply.github.com>
Co-authored-by: Ashwin Thyagarajan <ashwin031192@gmail.com>
Co-authored-by: Penguine-Os <yenebeb.df@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home page and Details page call GetDueClass
2 participants