Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Details page make labels less visible #128

Closed
Tracked by #127
chrisK00 opened this issue Sep 13, 2023 · 2 comments
Closed
Tracked by #127

Details page make labels less visible #128

chrisK00 opened this issue Sep 13, 2023 · 2 comments
Labels
subtask Task of an Epic aka Story, part of a larger task

Comments

@chrisK00
Copy link
Contributor

chrisK00 commented Sep 13, 2023 •
edited
Loading

I'm not a big fan over the fact that the labels are in the same font and have the same alpha as the actual values. The dividers are also a bit distracting and we don't need as many as we currently have.

Acceptance criteria

  • The divider above the mark paid button has been removed
  • The divider below delete button has been removed
  • All dividers have a little less alpha values (decrease transparency)
  • All labels are just a tiny bit smaller then previously and have a little less alpha values (decrease transparency)
  • A screenshot of the result has been added to the pull request on github
@chrisK00 chrisK00 added the subtask Task of an Epic aka Story, part of a larger task label Sep 13, 2023
@chrisK00 chrisK00 mentioned this issue Sep 13, 2023
Closed
4 tasks
@kgrontis
Copy link
Contributor

How does this look?
image

@chrisK00
Copy link
Contributor Author

How does this look?
image

Alpha is good. Font looks a bit too small, maybe increase it with like 1 pixel?

kgrontis added a commit that referenced this issue Sep 18, 2023
@kgrontis
#128 make labels less visible
3af5498
@kgrontis kgrontis mentioned this issue Sep 18, 2023
Merged
kgrontis added a commit that referenced this issue Sep 18, 2023
@kgrontis @chrisK00
#128 make labels less visible (#136)
38dbfa6 
* #128 make labels less visible

* Update subtrack.MAUI/wwwroot/css/app.css

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>
@chrisK00 chrisK00 mentioned this issue Sep 20, 2023
Closed
chrisK00 added a commit that referenced this issue Sep 24, 2023
@chrisK00 @kgrontis
@denislavh @ashwin003 @Penguine-Os
Release 2.1.0 (#146)
521799d 
* Update README.md

* Update README.md

* revert version

* revert comments

* companyname

* Update README.md

* #114 Implemented CssUtil.GetDueClass & tests (#123)

* #114 Implemented CssUtil.GetDueClass & tests

* #114 Added semicolor to css rule

* #114 Changed placement of css rule.

* #114 removed dots from string result.

* #114 PR review changes.

* #115 Added call to GetDueClass method in monthly page. (#124)

* add mockups for icons and colors

* Adds font color to due period depending on severity. (#126)

* Adds font color to due period depending on severity.

* Returns text-end class for Index page.

* Preserves newline in subscription description (#131)

* Introduces subscription background color. (#135)

* Adds background color to the database

* Adds a control to select background color for a subscription

* Updates tests to include background color

* Updates migration scripts

* Update subtrack.MAUI/Utilities/CssUtil.cs

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor updates

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor adjustments

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #128 make labels less visible (#136)

* #128 make labels less visible

* Update subtrack.MAUI/wwwroot/css/app.css

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #125 Added US Culture as a constant (#144)

* #142 Fixed descriptions not displayed correctly. (#145)

* update roadmap

* make nav buttons larger and remove outline on back save and edit buttons (#143)

* btn outline => btn filled

* navbar simplification

* resolve comments

* format and remove non existing css class

* remove default styling

---------

Co-authored-by: ChrisK00 <christian.khalil2000@gmail.com>
Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

---------

Co-authored-by: Konstantinos Grontis <grodiscostas@hotmail.com>
Co-authored-by: denislavh <53407843+denislavh@users.noreply.github.com>
Co-authored-by: Ashwin Thyagarajan <ashwin031192@gmail.com>
Co-authored-by: Penguine-Os <yenebeb.df@gmail.com>
chrisK00 added a commit that referenced this issue Nov 1, 2023
@chrisK00 @kgrontis
@denislavh @ashwin003 @Penguine-Os
Release v2.2.0 (#153)
2c867da 
* Update README.md

* Update README.md

* revert version

* revert comments

* companyname

* Update README.md

* #114 Implemented CssUtil.GetDueClass & tests (#123)

* #114 Implemented CssUtil.GetDueClass & tests

* #114 Added semicolor to css rule

* #114 Changed placement of css rule.

* #114 removed dots from string result.

* #114 PR review changes.

* #115 Added call to GetDueClass method in monthly page. (#124)

* add mockups for icons and colors

* Adds font color to due period depending on severity. (#126)

* Adds font color to due period depending on severity.

* Returns text-end class for Index page.

* Preserves newline in subscription description (#131)

* Introduces subscription background color. (#135)

* Adds background color to the database

* Adds a control to select background color for a subscription

* Updates tests to include background color

* Updates migration scripts

* Update subtrack.MAUI/Utilities/CssUtil.cs

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor updates

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor adjustments

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #128 make labels less visible (#136)

* #128 make labels less visible

* Update subtrack.MAUI/wwwroot/css/app.css

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #125 Added US Culture as a constant (#144)

* #142 Fixed descriptions not displayed correctly. (#145)

* update roadmap

* make nav buttons larger and remove outline on back save and edit buttons (#143)

* btn outline => btn filled

* navbar simplification

* resolve comments

* format and remove non existing css class

* remove default styling

---------

Co-authored-by: ChrisK00 <christian.khalil2000@gmail.com>
Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Adds subscription icon and secondary color (#149)

* Adds database columns for icon and secondary color

* Adds controls for saving icon and secondary color for subscriptions

* Use subscription icon and secondary colors in the UI

* Updates migration scripts

* Minor updates to UI

* Minor UI updates

* Updates subscription details title

* Updates subscription details title

* fix flaky test

* Revert "fix flaky test"

This reverts commit b3bb61d.

* Feature/improve subscription card design poc (#150)

* fix create sub bug. New style for cards. use dot instead of comma

* fix overflow color picker input. fix currency on index showing on newline

* fix flaky test

* fix flaky test

* roadmap

---------

Co-authored-by: Konstantinos Grontis <grodiscostas@hotmail.com>
Co-authored-by: denislavh <53407843+denislavh@users.noreply.github.com>
Co-authored-by: Ashwin Thyagarajan <ashwin031192@gmail.com>
Co-authored-by: Penguine-Os <yenebeb.df@gmail.com>
chrisK00 added a commit that referenced this issue Nov 5, 2023
@chrisK00 @kgrontis
@denislavh @ashwin003 @Penguine-Os
v2.2.1-alpha (#156)
a1a64dc 
* Update README.md

* Update README.md

* revert version

* revert comments

* companyname

* Update README.md

* #114 Implemented CssUtil.GetDueClass & tests (#123)

* #114 Implemented CssUtil.GetDueClass & tests

* #114 Added semicolor to css rule

* #114 Changed placement of css rule.

* #114 removed dots from string result.

* #114 PR review changes.

* #115 Added call to GetDueClass method in monthly page. (#124)

* add mockups for icons and colors

* Adds font color to due period depending on severity. (#126)

* Adds font color to due period depending on severity.

* Returns text-end class for Index page.

* Preserves newline in subscription description (#131)

* Introduces subscription background color. (#135)

* Adds background color to the database

* Adds a control to select background color for a subscription

* Updates tests to include background color

* Updates migration scripts

* Update subtrack.MAUI/Utilities/CssUtil.cs

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor updates

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor adjustments

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #128 make labels less visible (#136)

* #128 make labels less visible

* Update subtrack.MAUI/wwwroot/css/app.css

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #125 Added US Culture as a constant (#144)

* #142 Fixed descriptions not displayed correctly. (#145)

* update roadmap

* make nav buttons larger and remove outline on back save and edit buttons (#143)

* btn outline => btn filled

* navbar simplification

* resolve comments

* format and remove non existing css class

* remove default styling

---------

Co-authored-by: ChrisK00 <christian.khalil2000@gmail.com>
Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Adds subscription icon and secondary color (#149)

* Adds database columns for icon and secondary color

* Adds controls for saving icon and secondary color for subscriptions

* Use subscription icon and secondary colors in the UI

* Updates migration scripts

* Minor updates to UI

* Minor UI updates

* Updates subscription details title

* Updates subscription details title

* fix flaky test

* Revert "fix flaky test"

This reverts commit b3bb61d.

* Feature/improve subscription card design poc (#150)

* fix create sub bug. New style for cards. use dot instead of comma

* fix overflow color picker input. fix currency on index showing on newline

* fix flaky test

* fix flaky test

* roadmap

* order by year (#154)

* readme merge master

* fix

* return url on delete

---------

Co-authored-by: Konstantinos Grontis <grodiscostas@hotmail.com>
Co-authored-by: denislavh <53407843+denislavh@users.noreply.github.com>
Co-authored-by: Ashwin Thyagarajan <ashwin031192@gmail.com>
Co-authored-by: Penguine-Os <yenebeb.df@gmail.com>
chrisK00 added a commit that referenced this issue Dec 11, 2023
@chrisK00 @kgrontis
@denislavh @ashwin003 @Penguine-Os
Release 2.3.1 (#164)
756c171 
* Update README.md

* Update README.md

* revert version

* revert comments

* companyname

* Update README.md

* #114 Implemented CssUtil.GetDueClass & tests (#123)

* #114 Implemented CssUtil.GetDueClass & tests

* #114 Added semicolor to css rule

* #114 Changed placement of css rule.

* #114 removed dots from string result.

* #114 PR review changes.

* #115 Added call to GetDueClass method in monthly page. (#124)

* add mockups for icons and colors

* Adds font color to due period depending on severity. (#126)

* Adds font color to due period depending on severity.

* Returns text-end class for Index page.

* Preserves newline in subscription description (#131)

* Introduces subscription background color. (#135)

* Adds background color to the database

* Adds a control to select background color for a subscription

* Updates tests to include background color

* Updates migration scripts

* Update subtrack.MAUI/Utilities/CssUtil.cs

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor updates

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/UpsertSubscription.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Minor adjustments

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #128 make labels less visible (#136)

* #128 make labels less visible

* Update subtrack.MAUI/wwwroot/css/app.css

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Update subtrack.MAUI/Pages/SubscriptionDetails.razor

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

---------

Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* #125 Added US Culture as a constant (#144)

* #142 Fixed descriptions not displayed correctly. (#145)

* update roadmap

* make nav buttons larger and remove outline on back save and edit buttons (#143)

* btn outline => btn filled

* navbar simplification

* resolve comments

* format and remove non existing css class

* remove default styling

---------

Co-authored-by: ChrisK00 <christian.khalil2000@gmail.com>
Co-authored-by: chrisK00 <72318023+chrisK00@users.noreply.github.com>

* Adds subscription icon and secondary color (#149)

* Adds database columns for icon and secondary color

* Adds controls for saving icon and secondary color for subscriptions

* Use subscription icon and secondary colors in the UI

* Updates migration scripts

* Minor updates to UI

* Minor UI updates

* Updates subscription details title

* Updates subscription details title

* fix flaky test

* Revert "fix flaky test"

This reverts commit b3bb61d.

* Feature/improve subscription card design poc (#150)

* fix create sub bug. New style for cards. use dot instead of comma

* fix overflow color picker input. fix currency on index showing on newline

* fix flaky test

* fix flaky test

* roadmap

* order by year (#154)

* readme merge master

* fix

* return url on delete

* Update README.md

* Creates a settings page with controls for importing and exporting subscriptions (#157)

* Implement exporting subscriptions (#158)

* export subs

* update roadmap

* Update dotnet.yml

* do not target IOS

* Update dotnet.yml

* global.json

* more permissive .net 7 sdk

* #147 Changed status bar color for android. (#159)

* net 7 (#160)

* Implement Importing subscriptions (#161)

* added lastsubexporttime (#162)

* roadmap

---------

Co-authored-by: Konstantinos Grontis <grodiscostas@hotmail.com>
Co-authored-by: denislavh <53407843+denislavh@users.noreply.github.com>
Co-authored-by: Ashwin Thyagarajan <ashwin031192@gmail.com>
Co-authored-by: Penguine-Os <yenebeb.df@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
subtask Task of an Epic aka Story, part of a larger task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kgrontis @chrisK00