Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nav buttons larger and remove outline on back, save and edit buttons #91

Closed
chrisK00 opened this issue Aug 15, 2023 · 3 comments · Fixed by #143
Closed

Make nav buttons larger and remove outline on back, save and edit buttons #91

chrisK00 opened this issue Aug 15, 2023 · 3 comments · Fixed by #143
Assignees
Labels
feature minor Increase the value of minor for the next release

Comments

@chrisK00
Copy link
Contributor

Acceptance Criteria

  • Home and monthly button should be slightly larger both width and height. Theres a line above them that is too close, it should also be slightly moved upwards
  • Back and Edit button on sub details should not be outlined
  • Back and Save button on sub upsert should not be outlined
  • A png of the page is attached to the Pull request (not the repository code)
  • Looks good on a ~1080x2400 (google pixel 5)
@Penguine-Os Penguine-Os self-assigned this Aug 25, 2023
@chrisK00 chrisK00 added the minor Increase the value of minor for the next release label Sep 8, 2023
@chrisK00
Copy link
Contributor Author

Hey @Penguine-Os, any updates on this?

@Penguine-Os
Copy link
Contributor

Penguine-Os commented Sep 18, 2023

Hi,
ive almost completed the task.
i would like to improve the navbar component...
I suggest to remove the "Home" & "Monthely" text al together and only keep the icons and mayebe replace the monthely icon with a calender icon think this is more inline with many ui/ux guidlines.

What do you think?

@chrisK00
Copy link
Contributor Author

Hi,
ive almost completed the task.
i would like to improve the navbar component...
I suggest to remove the "Home" & "Monthely" text al together and only keep the icons and mayebe replace the monthely icon with a calender i think this is more inline with many ui/ux guidlines.

What do you think?

Hey, I think a calendar icon instead of the current one on monthly sounds great. Regarding removing the text below the icons afaik its very common to have an icon and then text that explains where it links to but Im a fan of simplicity so give it a try! If you remove the text make sure to make the icons larger so they are easy to click

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature minor Increase the value of minor for the next release
Projects
None yet
2 participants