Prevent crash for malformed mining activity. #46020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
added
the
[C++]
2 tasks
This was referenced Mar 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Fixes #42900
It turns out that going forward this was already fixed by #44841, but these changes by andr8i prevent a crash as well.
Describe the solution
Check for presence of a tool target before dereferencing it.
Describe alternatives you've considered
This isn't SUUUPER necessary, because a previous PR fixed the code that sets it, but this is nice and robust, and tells us whent wrong when it goes wrong.
Testing
Spawn and befriend a NPC.
Spawn a pickaxe.
Visit a basement.
Set a mining zone ( Y -> add zone -> mining zone ) on the wall.
Give the NPC the pickaxe.
C hat at the NPC, ask them what they're (d)oing, (h)arangue NPC about their activity (cancel it and start over if necessary), (e)ncourage the NPC to start mining.
Wait for the NPC to finish mining out a tile.
No crash.