Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zone mining crash #44841

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Conversation

Trioct
Copy link
Contributor

@Trioct Trioct commented Oct 13, 2020

Summary

SUMMARY: Bugfixes "Fix zone mining crash"

Purpose of change

Fixes #39704
Fixes #44642 (duplicate)
Fixes crash when finishing a mining activity done through zones

Describe the solution

#37910 changed ACT_PICKAXE to use activity arguments in a better way. It changed the function for mining without zones, just missed the function for starting the activity with zones

Describe alternatives you've considered

N/A

Testing

Can now mine with zones without crashing (from this bug, at least)

@ZhilkinSerg ZhilkinSerg merged commit 1ce9420 into CleverRaven:master Oct 14, 2020
@Trioct Trioct deleted the fix-zone-mining-crash branch October 14, 2020 12:29
@anothersimulacrum anothersimulacrum added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` labels Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfault when mining a wall using the zone menu Crash upon completion of Mining Task
3 participants