Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port DDA's fixes for mining activity #421

Merged
merged 3 commits into from
Mar 30, 2021
Merged

Port DDA's fixes for mining activity #421

merged 3 commits into from
Mar 30, 2021

Conversation

olanti-p
Copy link
Contributor

Purpose of change

Fixes #407

Describe the solution

Cherry-picked CleverRaven#44841 and CleverRaven#46020

Testing

Provided save file stopped crashing

@Coolthulhu Coolthulhu merged commit 953f080 into cataclysmbnteam:upload Mar 30, 2021
@Coolthulhu
Copy link
Member

I wonder how is the malformed activity created. This will help to find it, at least.
It might not fix another possible crash, with a well-formed activity becoming buggy after inventory restack, which scrambles item positions and thus item_locations as well. I'm thinking how to test it.

@olanti-p olanti-p deleted the fix-mining branch March 30, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when NPC is mining
4 participants
@olanti-p @Coolthulhu @Trioct @andrei8l