Apply effects from passive enchantments #43101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fris0uman
changed the title
anothersimulacrum
added
<Bugfix>
|
Will this affect mutation enchantments as well or just bionic ones and what seems like equipment(+1dex ring)? |
added 2 commits
August 24, 2020 20:53
ZhilkinSerg
added
Mechanics: Effects / Skills / Stats
Ramza13
pushed a commit
to Ramza13/Cataclysm-DDA
that referenced
this pull request
Sep 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Apply effects from passive enchantments
fixes #43105
Describe the solution
Add one line to activate_passive() in suffer()
Add tests to check enchantments keep working
Describe alternatives you've considered
Testing
Dig up test enchantment from #39563
Install the bionic
Get +25 strenght and be invisible
Wear a +1dex ring > get +1 dex
Run the tests without errors
Additional context