Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effects provided by enchantments aren't being applied #43105

Closed
MutaMan opened this issue Aug 21, 2020 · 0 comments · Fixed by #43101
Closed

Effects provided by enchantments aren't being applied #43105

MutaMan opened this issue Aug 21, 2020 · 0 comments · Fixed by #43101
Labels
Artifacts Otherworldly items with special effects Bionics CBM (Compact Bionic Modules) <Bug> This needs to be fixed

Comments

@MutaMan
Copy link

MutaMan commented Aug 21, 2020

Describe the bug

A few CBMs my character has aren't applying their effects, namely the cloaking system and artificial night generator CBMs. I made a new base world to see if it's the same case and it was. I checked to see what they do, noted via the cloaking system in additional context (a), and it looks like they're using enchantments to produce their results. Noted in additional context (b) is the enchantment itself, and in (c) is the effect the enchantment is supposed to provide. At first I thought it was enchantments in general, but the ink glands enchantment works, mutation noted in additional context (d), except that it's a different type of enchantment, one that casts a spell, noted in additional context (e) and (f). This lead me to the conclusion that it's only effects that are affected from this bug affecting enchantments.

Steps To Reproduce

Testing, for CBMs:

  1. Acquire and install Cloaking System CBM.
  2. Activate it.
  3. After a few turns of waiting, check status screen and confirm that Invisibility is not shown on the effects summary.
  4. Examine monsters that you're in vision range of, and see that it states they can see you.

Testing, for mutations:

  1. Add the following to a mutation, preferably one available during character creation: "enchantments": [ "ENCH_INVISIBILITY" ]
  2. Start play with said mutation, or acquire it via debug.
  3. After a few turns of waiting, check status screen and confirm that Invisibility is not shown on the effects summary.
  4. Examine monsters that you're in vision range of, and see that it states they can see you.
  5. Debug in the Ink Glands mutation.
  6. Allow an enemy to hit you until Ink Spray triggers, confirming that it's specific to ench_effects rather than enchantments in general.

Expected behavior

The activation of the cloaking system CBM should activate the enchant which should then apply the invisibility effect and make it so that monsters/entities cannot percieve you by sight.

Screenshots

Spitter zombie can see me:
spitter zombie can see me
Despite the CBMs being on:
CMBs are on
Status screen to show the invisibility effect isn't showing there either:
effect not showing

Versions and configuration

  • OS: Windows 10
  • Game Version: 0.E-5263-gea59b32
  • Graphics version: Tiles
  • Ingame language: English
  • Mods loaded: dda

Additional context

(a): https://github.com/CleverRaven/Cataclysm-DDA/blob/master/data/json/bionics.json#L264
(b): https://github.com/CleverRaven/Cataclysm-DDA/blob/master/data/json/enchantments.json#L4
(c): https://github.com/CleverRaven/Cataclysm-DDA/blob/master/data/json/effects.json#L640
(d): https://github.com/CleverRaven/Cataclysm-DDA/blob/master/data/json/mutations/mutations.json#L2798
(e): https://github.com/CleverRaven/Cataclysm-DDA/blob/cfbd1421b24bbd7dc823ef8545eb5f1833fd063d/data/json/mutations/mutation_enchantments.json
(f) https://github.com/CleverRaven/Cataclysm-DDA/blob/2dcc333432989cfcc22e6dd494ac0f7eec9979cc/data/json/mutations/mutation_spells.json

@MutaMan MutaMan changed the title Cloaking system CBM not providing invisibility effect Effects provided by enchantments aren't being applied Aug 21, 2020
@KorGgenT KorGgenT added <Bug> This needs to be fixed Artifacts Otherworldly items with special effects Bionics CBM (Compact Bionic Modules) labels Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Artifacts Otherworldly items with special effects Bionics CBM (Compact Bionic Modules) <Bug> This needs to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants