Add enchantments to bionics #39563
Merged
Add enchantments to bionics #39563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7ce05e0.
curstwist
added
Bionics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Add enchantments to bionics"Purpose of change
Add enchantments to bionics
Use it to have bionic emit fields and apply effects
Describe the solution
Describe alternatives you've considered
Testing
Make an enchantments that apply invisibility effect, emit sparks and give +30 str
Put enchantments in night generator CBM
Get cbm and turn it on
Die in blaze of sparks while zombies ignore you > working as intended
Additional context
I took the doc from #34667
Also I'm not sure how emitter is going to behave, since enchantments can only emit one field the last one to be added to the enchantment_cache will override the others.