Mining multi-activity for NPCs and players #38505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[C++]
|
This is another feature I've been hankering for, thanks! The utility of this is a bit lacking at the moment until NPCs work when they're on a different Z level. If the issue hasn't been raised yet I'll go do that now and link it. Edit: It wasn't raised, here we go! #38516 |
ghost
requested a review
from
ZhilkinSerg
force-pushed
the
dev
branch
2 times, most recently
from
aa39539 to
9761f13
Compare
ZhilkinSerg
force-pushed
the
dev
branch
6 times, most recently
from
924f105 to
39e00e3
Compare
ZhilkinSerg
force-pushed
the
dev
branch
3 times, most recently
from
ad63e77 to
8e68539
Compare
kevingranade
force-pushed
the
dev
branch
4 times, most recently
from
621a68e to
b7106d0
Compare
ZhilkinSerg
force-pushed
the
dev
branch
3 times, most recently
from
0f30a43 to
d432807
Compare
added 9 commits
April 2, 2020 16:25
|
Rebased, retargeted, retested - working fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Features "Mining multi-activity for NPCs and players"Purpose of change
Mining multi-activity for NPCs and players
Describe the solution
A new multi-type activity - Mining.
NPC/player will auto-fetch tools, and go and mine in a designated area, clearing up all the products to an unsorted zone nearby.
Not much use for it as things stand really, but mods/scenarios/future features may make an underground base more desirable.
And I guess you do get lots of coal and limestone sometimes.
Describe alternatives you've considered
N/A
Testing
Found two bugs during this in activity code, which I did fixes for in #38503
and
#38504
These fixes were already in another of my feature-freezed PRs, but they needed to be split out.
So those changes are in this PR too, for the purposes of testing, and with this, I tested with electric jackhammers, pickaxes etc, and the NPC went and picked it up and went and did the work, and tidied up the rocks and stuff afterwards.
Additional context
N/A