Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPCs finish activities if they're on a different Z level #38516

Open
Funguss opened this issue Mar 2, 2020 · 2 comments
Open

NPCs finish activities if they're on a different Z level #38516

Funguss opened this issue Mar 2, 2020 · 2 comments
Labels
<Bug> This needs to be fixed NPC / Factions NPCs, AI, Speech, Factions, Ownership Z-levels Levels below and above ground.

Comments

@Funguss
Copy link
Contributor

Funguss commented Mar 2, 2020

Currently NPCs stop performing actions if they're located on a different Z level from the PC. This is especially noticeable with short running tasks like Sort Loot

Seems I mistook one bug for another. The bug I was describing is an old one that's no longer an issue for sort loot, may still exist for other zone types. The actual bug I had encountered was that loot zones are ignored if they're on a different Z level; unsorted on Z1, for instance, and loot zones on Z0. Asking an NPC to farm when the plot is on Z0 and the NPC is on Z1 also causes this.

Steps To Reproduce

  1. Position an (unsorted) zone / zones nearby a staircase.
    ~~2. Set NPCs to work in these zones.
  2. Move up / down the stairs and wait until they finish their tasks.~~
  3. Place a custom zone with no filter up / down stairs.
  4. Start sorting loot / ask NPC to.
  5. Check zones. Depending on how quickly you moved Z level very little work will be completed.

Expected behavior

Z levels shouldn't impact NPC behaviour as it's all simulated now.

Versions and configuration

  • OS: Windows
    • OS Version: MINGW/CYGWIN/MSYS2 on unknown Windows version
  • Game Version: 0.D-12725-ge035f12 [64-bit]
  • Graphics Version: Tiles
  • Mods loaded: [
    Dark Days Ahead [dda],
    Aftershock [aftershock],
    C.R.I.T Expansion Mod [crt_expansion],
    Magiclysm [magiclysm],
    Makeshift Items Mod [makeshift],
    More Survival Tools [More_Survival_Tools],
    Mythological Replicas [nw_pack],
    Hydroponics [hydroponics],
    Mutant NPCs [mutant_npcs],
    No Rail Stations [No_Rail_Stations],
    Folding Parts pack [deoxymod],
    Vehicle Additions Pack [blazemod],
    Tanks and Other Vehicles [Tanks],
    Roadheader and other mining vehicles [Heavy miners],
    No Fungal Monsters [No_Fungi],
    Beta National Guard Camp [national_guard_camp]
    ]
@kevingranade kevingranade added <Bug> This needs to be fixed NPC / Factions NPCs, AI, Speech, Factions, Ownership Z-levels Levels below and above ground. labels Mar 4, 2020
@ghost
Copy link

ghost commented Mar 9, 2020

Zones arent z-level aware in general.
I don't know how difficult itd be to make them scannable across z-levels, as they are cached... and it gets pretty gnarly.

This woul dbe a bug for avatar activities on other z-levels too id imagine, if the target zone of their activity was on a different z-level.

@Funguss
Copy link
Contributor Author

Funguss commented Mar 9, 2020

That's true. Farming doesn't cause you or followers to take the stairs, and yes, I tried sending the avatar to sort loot from the upstairs of a building to the downstairs but it doesn't happen. It's very nice that work done on a Z level continues when the avatar is above/below, though. That helps immensely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed NPC / Factions NPCs, AI, Speech, Factions, Ownership Z-levels Levels below and above ground.
Projects
None yet
Development

No branches or pull requests

2 participants