Stop crashing when NPC picks up item in fetching activity #38503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
ZhilkinSerg
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Stop crashing when NPC picks up item in fetching activity"Purpose of change
Stop crashing when NPC picks up item in fetching activity
Describe the solution
Surprised this wasnt logged, but in my testing on something else, it always crashed when NPC picked up a tool as a result of the fetching activity.
This was due to it trying to access the name after the iterator had been invalidated ( maybe this wa sa regression of sorts at some point? it wasnt doing this last time I was working in this area, weeks ago )
Fixes that by moving the message block before the iterator is invalidated.
Describe alternatives you've considered
N/A
Testing
Before - ask NPC to fish, they go and fetch rod, it crashes when they pick it up.
After - it dosnt crash.
Additional context
N/A