Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace three ascii dots with the unicode ellipsis in the c++ code #34777

Merged
merged 2 commits into from
Oct 17, 2019

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Oct 15, 2019

Summary

SUMMARY: None

Purpose of change

Replace the currently pervasive usage of three ascii dots in the c++ code with actual unicode ellipses.

Describe the solution

Ran the clang-tidy text style check to do the replacement.

Describe alternatives you've considered

According to #34492, some fonts have poor support for unicode symbols, so this might not work well for the user of such fonts. I think the ultimate solution would be using fallback fonts, similar to the way unsupported symbols are handled in a browser, etc, but if it turns out to not work, we can hold off this change and disable the ellipses check in clang-tidy for the time being.

@kevingranade
Copy link
Member

I am not aware of a way to even detect missing characters in curses, much less do anything about it.
The only thing that comes to mind is providing alternate strings for any unicode strings we use and toggling back to the ascii version with an option.

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Translation I18n labels Oct 16, 2019
@ZhilkinSerg ZhilkinSerg merged commit 8f0f6bb into CleverRaven:master Oct 17, 2019
@Qrox Qrox deleted the ellipses branch October 18, 2019 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants