Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⍰ symbol in weapon names and on UI. #34492

Closed
Myobu1 opened this issue Oct 5, 2019 · 11 comments · Fixed by #37573
Closed

⍰ symbol in weapon names and on UI. #34492

Myobu1 opened this issue Oct 5, 2019 · 11 comments · Fixed by #37573
Labels
<Bug> This needs to be fixed Info / User Interface Game - player communication, menus, etc.

Comments

@Myobu1
Copy link

Myobu1 commented Oct 5, 2019

For some reason, I've noticed a ⍰ symbol appear in-game. I first noticed it when I found a S&W 610 on the ground. It read as "⍰S&W 610" - However, guns spawned in using debug mode appear normal. The ⍰ symbol isn't appearing in the name of every gun, but I managed to find a few after I teleported to several gunstores. The ⍰ symbol also appears next to "Calm" on the UI. I reinstalled the game and ensured my graphics drivers were updated, but the problem persists.

If I'm the only one with this issue, I'll assume that it's on my end and reinstall my OS.

Screenshot (139)
Screenshot (140)
Screenshot (141)

OS: Windows 10 Professional
Game Version: 0.D-8222-g9213915
Graphics Version: Tiles
Mods loaded: No Flaming Weapons, No Survivor Armor, Disable NPC Needs

@anothersimulacrum
Copy link
Member

@snipercup
Copy link
Contributor

It looks like this on my machine:
image

  • OS: Windows
    • OS Version: MINGW/CYGWIN/MSYS2 on unknown Windows version
  • Game Version: 0.D-8206-gedf3542 [64-bit]
  • Graphics Version: Tiles
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food]
    ]
    I got windows 8.1

In the comments of the pr that anothersimulacrum is pointing to it says:

// these symbols are unicode square characeters of different heights, representing a rough
// estimation of fouling in a gun. This appears instead of "faulty"
// since most guns will have some level of fouling in them, and usually it is not a big deal.

Maybe there is a problem with some fonts? Is there an alternative to represent dirt level?

@anothersimulacrum
Copy link
Member

Is there an alternative to represent dirt level?

Put it in the description?

@Myobu1
Copy link
Author

Myobu1 commented Oct 5, 2019

Well, I am using the font settings Vormithrax recommends - the "Whitrabt" and "Consolas Bold" fonts. However, if the only option to fix this issue is to revert to vanilla fonts... I guess I'll have to live with it.

Edit: Apparently setting my font back to Unifont fixes the issue. But I shouldn't have to change my font to have a feature display properly.

@anothersimulacrum
Copy link
Member

anothersimulacrum commented Oct 5, 2019

Oh yeah, Whiterabbit doesn't have (much) unicode support. So any font without unicode support won't work with this feature. (This should be fixed)

@ZhilkinSerg
Copy link
Contributor

But I shouldn't have to change my font to have a feature display properly.

Your font has poor Unicode support (well, to be honest most fonts are not as good as unifont, so...).

@Myobu1
Copy link
Author

Myobu1 commented Oct 5, 2019

I'm not using Whiterabbit for my typeface, just the map. I'm using Consolas Bold for everything else, and that isn't an uncommon font by any means. In addition, those fonts are far easier on the eyes for me to read than Unifont.

Anyway, why should being able to see if a weapon has been fouled be dependent on the user using Unifont? Couldn't that information be put in the description or something? Somewhere that isn't dependent on the user's font? My eyes aren't great, and Unifont looks like bad on my screen. It may look fine to you, but it doesn't look good nor clear to me.

I'm sorry if I'm being snippy, but the idea of being locked into using a single font frustrates me immensely.

@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed Info / User Interface Game - player communication, menus, etc. labels Oct 6, 2019
@Qrox
Copy link
Contributor

Qrox commented Oct 6, 2019

Is there a way to detect if a symbol is not supported by the current font and fallback to ascii symbols in such case?

@ANickelN
Copy link
Contributor

ANickelN commented Oct 7, 2019

Going to add a +1 for putting it in the description. Even with Unifont it still looks like an error/out of place.

@Qrox
Copy link
Contributor

Qrox commented Dec 26, 2019

@myobu Now that #36326 is merged, you can specify fallback fonts on the tiles build by changing the "typeface" value in config/fonts.json to an array. For example, since you're previously using Consolas Bold as the main font, now you can change "typeface": "consolab" to "typeface": [ "consolab", "unifont" ], so that missing symbols from Consolas will be displayed using unifont instead. Let me know if this addresses your problem.

@ZhilkinSerg
Copy link
Contributor

Unifont should be a default fallback probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants