Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the default font to Terminus and slightly improve fallback handling #37573

Merged
merged 2 commits into from
Jan 31, 2020

Conversation

ifreund
Copy link
Contributor

@ifreund ifreund commented Jan 31, 2020

Summary

SUMMARY: Interface "Return the default font to Terminus and slightly improve fallback handling."

Purpose of change

Fixes #34492

Terminus is simply prettier than unifont and many were sad to see it go in #19965. Luckily @Qrox recently added fallback support for fonts and effectively negated the issues leading to the switch to unifont.

In addition to that, we currently don't have a square map and overmap font by default, perhaps because of how ugly unifont looks at 16x16.

Describe the solution

  • Make Terminus the default font
  • Prevent users from shooting themselves in the foot by always loading unifont as a fallback even if it is not specified
  • Make the default (over)map font square

Testing

Loading fonts in various configurations and checking the description of the language option to see if fallback worked.

This prevents users from shooting themselves in the foot by selecting a
different font and removing unifont from their font list
@ifreund ifreund added <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` labels Jan 31, 2020
@Muffindrake
Copy link
Contributor

The gentoo wiki denounces GNU Unifont as 'ugly as sin'. I can't believe that choice was made, it should only be dead last in a fallback list, but I'm not invested because I don't play Tiles.

Besides that, I'd have a recommendation in terms of default fonts. https://github.com/pcaro90/hermit

Return the default font to Terminus

Make the (over)map font square
@ifreund ifreund force-pushed the sane-font-defaults branch from 7e0690a to 4d4dbef Compare January 31, 2020 01:44
@esotericist
Copy link
Contributor

The gentoo wiki denounces GNU Unifont as 'ugly as sin'. I can't believe that choice was made, it should only be dead last in a fallback list, but I'm not invested because I don't play Tiles.

Besides that, I'd have a recommendation in terms of default fonts. https://github.com/pcaro90/hermit

find us a better single monospace font that covers all of our language support requirements, and we'll be happy to use it as default.

hermit fails that standard.

@esotericist
Copy link
Contributor

esotericist commented Jan 31, 2020

Fixes #34492

probably

@Muffindrake
Copy link
Contributor

Every relevant font renderer has fallback mechanisms for missing fonts, unless I'm wrong on this one. Terminus certainly isn't high up on the list of 'next-gen exciting fonts', so I merely suggested one additional font as an alternative.

@ZhilkinSerg ZhilkinSerg added the SDL: Tiles / Sound Tiles visual interface and sounds. label Jan 31, 2020
@ZhilkinSerg ZhilkinSerg merged commit 5d5194c into CleverRaven:master Jan 31, 2020
@ifreund
Copy link
Contributor Author

ifreund commented Jan 31, 2020

@Muffindrake I believe there's been a bit of a misunderstanding. If you check out #19965 you can see that we only used unifont by default because we lacked a font fallback mechanism, a lack which has just recently been corrected. Terminus may not be "exciting" but it was the default font of tiles builds of CDDA when I first played and fits the role of a readable default quite well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON SDL: Tiles / Sound Tiles visual interface and sounds.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⍰ symbol in weapon names and on UI.
4 participants