Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating help for 0.D #27900

Merged
merged 26 commits into from
Jan 30, 2019
Merged

Updating help for 0.D #27900

merged 26 commits into from
Jan 30, 2019

Conversation

Firestorm01X2
Copy link
Contributor

@Firestorm01X2 Firestorm01X2 commented Jan 26, 2019

Updating help for 0.D.

I am going to focus only on thigs that is clearly false and misguided.

Summary

SUMMARY: Content "Updating help for 0.D"

Purpose of change

Dispite being very abstract, now help contain some outdated info. It is better to revise it slightly.

Describe the solution

I am going to focus only on things that is clearly false and misguided.

Describe alternatives you've considered

Full help rewriting.

Additional context

Changed:

  • Removed for handguns However, their small size makes them appropriate for short-range combat, where larger guns fare poorly. Not really. Greater damage and automatic fire solves the problem. But "Small size " - yes and "appropriate for short-range combat"- yes too.
  • Hunting rifles: referenced as Sniper and Marksman rifles. It is effectve on distances "at very long range" but not 10 tiles as it was long time ago. Also removed mention that they are less accurate upclose.
  • Aiming: adding referrence to aiming process.
  • CBM: no more "Bionics come in ready-to-install canisters.". It is confusing. Added direct referece to Autodoc, anastetic kits and narcosis.
  • Removed FAQ question:
    "Q: Shotguns bring in more zombies than they kill! What's the point?\nA: Shotguns are intended for emergency use. If you are cornered, use your shotgun to escape, then just run from the zombies it attracts.". There is nothing special in shotgun loud shots. Every noncilenced firerarm usually are loud enough to attract a lot of nearby zombies. Probably it is tip from early day dynamic spawn or something when gun loundess was different. And shotguns "are intended for emergency use" not much more more than other high damage guns. This question definetely overplays shotguns power and role.
  • Removed "machineguns are poor melee weapon".
  • Removed exsesive warnings about shotgun noise and shogun zombie attraction. Not completely, however. It make sense.
  • Removed mentioning of old dynamic spawn.
  • Added new FAQ question: "Q: There are too many calibers and guns. It confuses me - I don't usually understand what is compatible with what.\nA: Try to remember few usual calibers: \n9x19 (or simply 9mm) - fits most basic pistols (Glock, for example) and SMGs, quite easy to find and gets job done versus usual zombies;\n 00 buckshot - for most shotguns. Very powerful against unarmored target at closer ranges;\n .223 (5.56) - for rifles. Good long range option.\n .308 (7.62) - for even more powerful rifles. Also good long range option.\n It should be enough in the beginning. Or even just grab any shotgun, fill it with buckshot and give them hell!".

Updating help for 0.D
@Firestorm01X2 Firestorm01X2 changed the title Updating help for 0.D [WIP] Updating help for 0.D Jan 26, 2019
data/help/texts.json Outdated Show resolved Hide resolved
data/help/texts.json Outdated Show resolved Hide resolved
data/help/texts.json Outdated Show resolved Hide resolved
data/help/texts.json Outdated Show resolved Hide resolved
@Firestorm01X2
Copy link
Contributor Author

Firestorm01X2 commented Jan 26, 2019

@ZhilkinSerg
Is double space rule applies here too? Look at other texts

Though it is relatively rare, certain areas of the world may be contaminated with radiation. It will gr...

There are single spaces

@Firestorm01X2
Copy link
Contributor Author

Jenkins, rebuild.

Firestorm01X2 added 5 commits January 26, 2019 18:26
fixed typo
Bionic
Warning about safe place while installing bionics.
styling
@ZhilkinSerg
Copy link
Contributor

@ZhilkinSerg
Is double space rule applies here too? Look at other texts

Though it is relatively rare, certain areas of the world may be contaminated with radiation. It will gr...

There are single spaces

Yeah, double whitespaces should everywhere. This wasn't addressed in help for some unknown reason.

at very long range
@Firestorm01X2
Copy link
Contributor Author

Firestorm01X2 commented Jan 26, 2019

Yeah, double whitespaces should everywhere. This wasn't addressed in help for some unknown reason.

At the same time chagning it everywhere in the help may lead to updating all translations. Probably it is not best idea.

New lines are no problen - it is has to be translated anyway.

Firestorm01X2 added 7 commits January 26, 2019 19:55
Removed FAQ line
…nge combat, where larger guns fare poorly

Removed  Handguns : However, their small size makes them appropriate for short-range combat, where larger guns fare poorly
Spaces
may be
beware of this
Beware of that.
data/help/texts.json Outdated Show resolved Hide resolved
data/help/texts.json Outdated Show resolved Hide resolved
Firestorm01X2 added 2 commits January 26, 2019 22:11
Removed mentioning of old dynamic spawn
Added new FAQ question
and smgs
data/help/texts.json Outdated Show resolved Hide resolved
Firestorm01X2 added 5 commits January 26, 2019 22:46
Fixing
Fixing more
Fixing again
comma
Adding discord channel to FAQ
@Firestorm01X2
Copy link
Contributor Author

Firestorm01X2 commented Jan 27, 2019

Let's finish it for now.
Ready.

@Firestorm01X2 Firestorm01X2 changed the title [WIP] Updating help for 0.D Updating help for 0.D Jan 27, 2019
@ZhilkinSerg ZhilkinSerg added <Documentation> Design documents, internal info, guides and help. Translation I18n [JSON] Changes (can be) made in JSON labels Jan 27, 2019
@ZhilkinSerg ZhilkinSerg added this to the 0.D milestone Jan 27, 2019
@Firestorm01X2
Copy link
Contributor Author

Should I create dublicate PR for master?

data/help/texts.json Outdated Show resolved Hide resolved
@ZhilkinSerg ZhilkinSerg self-assigned this Jan 28, 2019
@ZhilkinSerg ZhilkinSerg merged commit 7757b62 into CleverRaven:0.D-branch Jan 30, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment Jan 30, 2019
kevingranade added a commit that referenced this pull request Jan 31, 2019
* 0.D-branch:
  Make dollchat items display their speech lines again
  Fixing position of morale and power on skinny siderbar
  Default text color for popups
  Overhauled default zombie drops
  Fix for Fish traits
  Add check against deploying a furniture item into same tile as a vehicle
  Add CSC_*_HIDDEN recipe subtab
  Fix items rotting while smoking outside of reality bubble.
  Setting default renderer for Windows to Direct3D for 0.D (#27915)
  Updating help for 0.D (#27900)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants