Setting default renderer for Windows to Direct3D for 0.D #27915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting default rendered fot Windows to Direct3D for 0.D
Firestorm01X2
changed the title
Firestorm01X2
changed the title
ZhilkinSerg
added
SDL: Tiles / Sound
ZhilkinSerg
reviewed
Jan 27, 2019
|
Jenkins, rebuild. |
added 2 commits
January 27, 2019 15:42
move renderer_list in #ifndef __ANDROID__
refactoring
ZhilkinSerg
reviewed
Jan 27, 2019
src/cata_tiles.cpp
Outdated
| } | ||
|
|
||
|
|
ZhilkinSerg
reviewed
Jan 27, 2019
added 2 commits
January 27, 2019 16:34
ZhilkinSerg
reviewed
Jan 27, 2019
added 2 commits
January 27, 2019 16:37
|
Finally it is builds. |
|
Warning! Before merging change must checked on non Windows environment. Just in case. |
|
It works for me on Windows 10 and Ubuntu. |
|
But for some reason I am still getting black lines graphical bug. But it is on VS build. Probably MXE build will be OK as some other players report. |
|
Ready. |
Firestorm01X2
changed the title
|
Are you going to merge it to master also? Or should I create adtional PR? |
|
You can create new PR against |
kevingranade
added a commit
that referenced
this pull request
Jan 31, 2019
* 0.D-branch: Make dollchat items display their speech lines again Fixing position of morale and power on skinny siderbar Default text color for popups Overhauled default zombie drops Fix for Fish traits Add check against deploying a furniture item into same tile as a vehicle Add CSC_*_HIDDEN recipe subtab Fix items rotting while smoking outside of reality bubble. Setting default renderer for Windows to Direct3D for 0.D (#27915) Updating help for 0.D (#27900)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting default renderer for Windows to Direct3D for 0.D
Player reports that it should help to avoid this:
#27731
Aka black lines around tiles.
It is workaround, but not bugfix.
Summary
SUMMARY: Content "Setting default renderer for Windows to Direct3D for 0.D"
I dont' want to call it "Bugfix", because it is not.
Purpose of change
#27731
But there is reports that setting default renderer to Direct3D allows to bypass the issue.
Linux and Android will still use default as "Software".
Describe the solution
Setting default rendered fot Windows to Direct3D for 0.D
Describe alternatives you've considered
This should be fixed. Somehow.
#27731
Also there is addtional workaround:
#27731 (comment)
Additional context
None.