Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDY] Restricts minimum texture size to fix crash during division by zero #22638

Merged
merged 2 commits into from
Dec 21, 2017

Conversation

ZhilkinSerg
Copy link
Contributor

@ZhilkinSerg ZhilkinSerg commented Dec 18, 2017

I don't know if it is a good solution, but should fix #22596.

Changes:

  • restricts minimum texture size to 128 sprites wide and 256 sprites high;
  • adds debug message about 0 max_texture-dimensions.

Test build (Win64 without data):

Unzip exe and dlls to existing Catcalysm folder, run Cataclysm-Tiles.exe and try to start new game or change Use tiles option in menu.

- restricts minimum texture size to 128 sprites wide and 256 sprites high;
- adds debug message about 0 `max_texture`-dimensions.

Fixes CleverRaven#22596
@ZhilkinSerg ZhilkinSerg changed the title Restricts minimum texture size to fix crash during division by zero [RDY] Restricts minimum texture size to fix crash during division by zero Dec 18, 2017
@ZhilkinSerg
Copy link
Contributor Author

@kevingranade, @codemime, @Coolthulhu, @Rivet-the-Zombie

Would someone please review and merge this PR asap. The crash is game breaking since build 7002.

@codemime codemime self-assigned this Dec 21, 2017
ZhilkinSerg added a commit to ZhilkinSerg/Cataclysm-DDA that referenced this pull request Dec 21, 2017
@codemime codemime merged commit 3e80249 into CleverRaven:master Dec 21, 2017
@ZhilkinSerg ZhilkinSerg deleted the sdl-fix-atlas-tile-split branch December 22, 2017 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Game started crashing after experimental build 7002
2 participants