Audit monster dissection proficiency allocation #68760
Labels
(P5 - Long-term)
Long-term WIP, may stay on the list for a while.
<Suggestion / Discussion>
Talk it out before implementing
Comments
PatrikLundell
added
the
<Suggestion / Discussion>
|
Anyone up for making a python script to build s list of monsters that lack proficiencies? |
Maleclypse
added
the
(P5 - Long-term)
|
Manually going through stuff (partial result, but the post is large enough to be split off):
|
|
|
|
|
|
That's finally the end of this survey. I'm not going to look at mods as there may be logic there I don't know anything about. |
|
I've got a PR draft #68197 that has weakpoints and proficiencies setup for amphibians. |
This was referenced Oct 28, 2023
Sounds like a perfect job for me! |
Maleclypse
pushed a commit
that referenced
this issue
Nov 7, 2023
* First Draft Changes: Add new monsters (mutant frog species & their tadpoles), eggs and monstergroups for them to reproduce and spawn. Add weakpoint sets for amphibians, and effects for those weakpoints. Old monsters have been replaced in monstergroups, and rotspawn/upgrade/reproduction references. For Megafauna mod as well. Updated all amphibian data in Tamable Wildlife. Fix my own poor judgement; change all instances of "toad" in id's to "frog" for consistency. * Update reptile_amphibian.json Change "Stuntongue" to "Taser Tongue" * Error fixes, Flag updates, Stink frog stinks Mostly error fixes. Add "SMALL_HIDE" flag to frogs, as suggested in #68387 Begin testing special abilities for foul toad line. Currently, tear gas emission for aerosolized bufotoxin; NO_BREATHE flag is an imperfect solution to them gassing themselves into submission. * Update egg.json Revert ID changes * Update amphibian.json Revert ID changes * Update eggs.json Revert ID changes * Update reptile_amphibian.json Revert ID changes Fix syntax error Rename 'Foul Hogtoad' to 'Giant Hogtoad.' * Update cooking_components.json Revert ID changes * Update wilderness.json Typo fix * Update reptile_amphibian.json Revert ID changes * Update reptile_amphibian.json Remove old monster IDs * Leaps & Flavor Text Clean up some descriptions. Adjust leap values for foul toad line. Add "NO_BREATHE" flag to foul toad line to prevent gassing by kin. * Give Croaker a Croak Add Shriek and Shriek_Stun to Colossal Croaker * Evo Rate, Taser Tongue Size, Hogtoad Flavor Update all amphibian evolution rates to account for default evo factor. Embiggen the taser tongue so it can pull PCs of higher than skeletal weight. Clean up giant hogtoad description for brevity and clarity. * Taser tongue-ing message, proxy tad no grow Change taser tongue tongue attack message Remove reproduction line from tadpole abstract * Growth Rate Fine Tune Increase timers for higher tier upgrades back to something reasonable * Clean Tongue Messages & Flavor Text Tidy up some descriptions and fix more repeated articles in tongue-dodging messages. * Stat tweaks, emissions, upgrade weights Minor changes to frog stats. Added new emit for stinktoad, gave weak emit to hogtoad. Adjusted weights within upgrade groups. * Update data/json/items/comestibles/egg.json Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com> * Update data/json/monsters/reptile_amphibian.json Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com> * Lower spawn rates * Incorporate Minor froggy edits #68748 Adjust spawn rates and default factions to match changes in #68748 * Typos Fix typos in great beaked toad description * Typos Fix typos in great beaked toad description * Syntax fix Remove extra space in description string * Add a missing 'R' Fix flag misspelling * MOM Monster Overrides Replace 'mon_frog_mega' with new mega frog references for monster regeneration overrides in Mind Over Matter. * First Draft Changes: Add new monsters (mutant frog species & their tadpoles), eggs and monstergroups for them to reproduce and spawn. Add weakpoint sets for amphibians, and effects for those weakpoints. Old monsters have been replaced in monstergroups, and rotspawn/upgrade/reproduction references. For Megafauna mod as well. Updated all amphibian data in Tamable Wildlife. Fix my own poor judgement; change all instances of "toad" in id's to "frog" for consistency. * Update reptile_amphibian.json Change "Stuntongue" to "Taser Tongue" * Error fixes, Flag updates, Stink frog stinks Mostly error fixes. Add "SMALL_HIDE" flag to frogs, as suggested in #68387 Begin testing special abilities for foul toad line. Currently, tear gas emission for aerosolized bufotoxin; NO_BREATHE flag is an imperfect solution to them gassing themselves into submission. * Update egg.json Revert ID changes * Update amphibian.json Revert ID changes * Update eggs.json Revert ID changes * Update reptile_amphibian.json Revert ID changes Fix syntax error Rename 'Foul Hogtoad' to 'Giant Hogtoad.' * Update cooking_components.json Revert ID changes * Update wilderness.json Typo fix * Update reptile_amphibian.json Revert ID changes * Update reptile_amphibian.json Remove old monster IDs * Leaps & Flavor Text Clean up some descriptions. Adjust leap values for foul toad line. Add "NO_BREATHE" flag to foul toad line to prevent gassing by kin. * Give Croaker a Croak Add Shriek and Shriek_Stun to Colossal Croaker * Evo Rate, Taser Tongue Size, Hogtoad Flavor Update all amphibian evolution rates to account for default evo factor. Embiggen the taser tongue so it can pull PCs of higher than skeletal weight. Clean up giant hogtoad description for brevity and clarity. * Taser tongue-ing message, proxy tad no grow Change taser tongue tongue attack message Remove reproduction line from tadpole abstract * Growth Rate Fine Tune Increase timers for higher tier upgrades back to something reasonable * Clean Tongue Messages & Flavor Text Tidy up some descriptions and fix more repeated articles in tongue-dodging messages. * Stat tweaks, emissions, upgrade weights Minor changes to frog stats. Added new emit for stinktoad, gave weak emit to hogtoad. Adjusted weights within upgrade groups. * Update data/json/items/comestibles/egg.json Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com> * Update data/json/monsters/reptile_amphibian.json Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com> * Lower spawn rates * Incorporate Minor froggy edits #68748 Adjust spawn rates and default factions to match changes in #68748 * Typos Fix typos in great beaked toad description * Update electronics.json * Fixing Itemgroups (#69011) * Fixing Itemgroups Fixing up some itemgroups and spawns * Update locations.json * Update clothing.json * Update clothing.json * fix typos * Bugfix: Ensure all selected books are scanned to ereader * Fixes issue where not all selected books were scanned to ereader. * The problem before was that: * `ebooksave_activity_actor` expected an exact number of calls to `do_turn()` until the current books was scanned. * But player speed affects the speed of activities such as this one. * In effect, `do_turn()` is called to few times compared to `to_turns<int>( duration )` when player speed > 100. * This change therefore makes sure that all selected books are fully scanned when the activity is finished, regardless of number of calls to `do_turn()`. * The number of calls to `do_turn()` does not really matter anyway, it's just used for supporting that some books are fully scanned while the activity is running. * display selected proficiency when opening proficiency UI from character display * add more (zombie) leather mask variant (#69013) * Update masks.json * Update data/json/items/armor/masks.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix pharmacy and doctor's office loot (#68995) * what the fuck * Update science_and_tech.json * rare drugs * painkillers * antiseptic powder * [Xedra Evolved] Misc additions (#68931) * Initial commit * spell check fixes * Thank you Ferret Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com> * Update gunmods.json --------- Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com> * Adjust hungry and overweight coloring in sidebar (#69005) * Update hunger.json * Update weight.json * Update sidebar-mobile.json * Update hunger.json * Remove boat hull coverage penalty for protrusions and carried vehicles (#69024) * Remove penalty from protrusions and carried parts when calculating boat hull coverage * Fix possible uninitialized value in vehicle.cpp * Increase(?) water drag coefficients for land vehicles with protrusions * Remove trailing zeroes in drag test JSON * Organize the remaining unorganized EOCs (#68940) * Organize the stuff * Update FREQUENTLY_MADE_SUGGESTIONS.md * Revert "Update FREQUENTLY_MADE_SUGGESTIONS.md" This reverts commit 0ca0c05. * Update FREQUENTLY_MADE_SUGGESTIONS.md * Organize the lab eocs * Opps, rename * try to fix some weirdness with Github * Syntax fix Remove extra space in description string * Add a missing 'R' Fix flag misspelling * MOM Monster Overrides Replace 'mon_frog_mega' with new mega frog references for monster regeneration overrides in Mind Over Matter. * MOM Overrides Fix No pattern megafrog, no regen * Effect & Family Updates -Tune up and capitalize Electrocution effect. -Add physiology dissection proficiency family to all frog monsters to match #68760 * Pattern Frog Flavor Touch up description text for pattern frogs --------- Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com> Co-authored-by: gettingusedto <78019001+gettingusedto@users.noreply.github.com> Co-authored-by: LordBarkBread <97002254+LordBarkBread@users.noreply.github.com> Co-authored-by: Tim Nordenfur <tim@gurka.se> Co-authored-by: inogenous <123803852+inogenous@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: KeremBaba <rasitkeremgulgun@gmail.com> Co-authored-by: Anton Simakov <67688115+GuardianDll@users.noreply.github.com> Co-authored-by: Risuga <oosyrag@gmail.com> Co-authored-by: Evan Balster <evan@interactopia.com> Co-authored-by: MNG-cataclysm <58958654+MNG-cataclysm@users.noreply.github.com>
Maleclypse
pushed a commit
to Maleclypse/Cataclysm-DDA
that referenced
this issue
Nov 16, 2023
) * First Draft Changes: Add new monsters (mutant frog species & their tadpoles), eggs and monstergroups for them to reproduce and spawn. Add weakpoint sets for amphibians, and effects for those weakpoints. Old monsters have been replaced in monstergroups, and rotspawn/upgrade/reproduction references. For Megafauna mod as well. Updated all amphibian data in Tamable Wildlife. Fix my own poor judgement; change all instances of "toad" in id's to "frog" for consistency. * Update reptile_amphibian.json Change "Stuntongue" to "Taser Tongue" * Error fixes, Flag updates, Stink frog stinks Mostly error fixes. Add "SMALL_HIDE" flag to frogs, as suggested in CleverRaven#68387 Begin testing special abilities for foul toad line. Currently, tear gas emission for aerosolized bufotoxin; NO_BREATHE flag is an imperfect solution to them gassing themselves into submission. * Update egg.json Revert ID changes * Update amphibian.json Revert ID changes * Update eggs.json Revert ID changes * Update reptile_amphibian.json Revert ID changes Fix syntax error Rename 'Foul Hogtoad' to 'Giant Hogtoad.' * Update cooking_components.json Revert ID changes * Update wilderness.json Typo fix * Update reptile_amphibian.json Revert ID changes * Update reptile_amphibian.json Remove old monster IDs * Leaps & Flavor Text Clean up some descriptions. Adjust leap values for foul toad line. Add "NO_BREATHE" flag to foul toad line to prevent gassing by kin. * Give Croaker a Croak Add Shriek and Shriek_Stun to Colossal Croaker * Evo Rate, Taser Tongue Size, Hogtoad Flavor Update all amphibian evolution rates to account for default evo factor. Embiggen the taser tongue so it can pull PCs of higher than skeletal weight. Clean up giant hogtoad description for brevity and clarity. * Taser tongue-ing message, proxy tad no grow Change taser tongue tongue attack message Remove reproduction line from tadpole abstract * Growth Rate Fine Tune Increase timers for higher tier upgrades back to something reasonable * Clean Tongue Messages & Flavor Text Tidy up some descriptions and fix more repeated articles in tongue-dodging messages. * Stat tweaks, emissions, upgrade weights Minor changes to frog stats. Added new emit for stinktoad, gave weak emit to hogtoad. Adjusted weights within upgrade groups. * Update data/json/items/comestibles/egg.json Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com> * Update data/json/monsters/reptile_amphibian.json Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com> * Lower spawn rates * Incorporate Minor froggy edits CleverRaven#68748 Adjust spawn rates and default factions to match changes in CleverRaven#68748 * Typos Fix typos in great beaked toad description * Typos Fix typos in great beaked toad description * Syntax fix Remove extra space in description string * Add a missing 'R' Fix flag misspelling * MOM Monster Overrides Replace 'mon_frog_mega' with new mega frog references for monster regeneration overrides in Mind Over Matter. * First Draft Changes: Add new monsters (mutant frog species & their tadpoles), eggs and monstergroups for them to reproduce and spawn. Add weakpoint sets for amphibians, and effects for those weakpoints. Old monsters have been replaced in monstergroups, and rotspawn/upgrade/reproduction references. For Megafauna mod as well. Updated all amphibian data in Tamable Wildlife. Fix my own poor judgement; change all instances of "toad" in id's to "frog" for consistency. * Update reptile_amphibian.json Change "Stuntongue" to "Taser Tongue" * Error fixes, Flag updates, Stink frog stinks Mostly error fixes. Add "SMALL_HIDE" flag to frogs, as suggested in CleverRaven#68387 Begin testing special abilities for foul toad line. Currently, tear gas emission for aerosolized bufotoxin; NO_BREATHE flag is an imperfect solution to them gassing themselves into submission. * Update egg.json Revert ID changes * Update amphibian.json Revert ID changes * Update eggs.json Revert ID changes * Update reptile_amphibian.json Revert ID changes Fix syntax error Rename 'Foul Hogtoad' to 'Giant Hogtoad.' * Update cooking_components.json Revert ID changes * Update wilderness.json Typo fix * Update reptile_amphibian.json Revert ID changes * Update reptile_amphibian.json Remove old monster IDs * Leaps & Flavor Text Clean up some descriptions. Adjust leap values for foul toad line. Add "NO_BREATHE" flag to foul toad line to prevent gassing by kin. * Give Croaker a Croak Add Shriek and Shriek_Stun to Colossal Croaker * Evo Rate, Taser Tongue Size, Hogtoad Flavor Update all amphibian evolution rates to account for default evo factor. Embiggen the taser tongue so it can pull PCs of higher than skeletal weight. Clean up giant hogtoad description for brevity and clarity. * Taser tongue-ing message, proxy tad no grow Change taser tongue tongue attack message Remove reproduction line from tadpole abstract * Growth Rate Fine Tune Increase timers for higher tier upgrades back to something reasonable * Clean Tongue Messages & Flavor Text Tidy up some descriptions and fix more repeated articles in tongue-dodging messages. * Stat tweaks, emissions, upgrade weights Minor changes to frog stats. Added new emit for stinktoad, gave weak emit to hogtoad. Adjusted weights within upgrade groups. * Update data/json/items/comestibles/egg.json Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com> * Update data/json/monsters/reptile_amphibian.json Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com> * Lower spawn rates * Incorporate Minor froggy edits CleverRaven#68748 Adjust spawn rates and default factions to match changes in CleverRaven#68748 * Typos Fix typos in great beaked toad description * Update electronics.json * Fixing Itemgroups (CleverRaven#69011) * Fixing Itemgroups Fixing up some itemgroups and spawns * Update locations.json * Update clothing.json * Update clothing.json * fix typos * Bugfix: Ensure all selected books are scanned to ereader * Fixes issue where not all selected books were scanned to ereader. * The problem before was that: * `ebooksave_activity_actor` expected an exact number of calls to `do_turn()` until the current books was scanned. * But player speed affects the speed of activities such as this one. * In effect, `do_turn()` is called to few times compared to `to_turns<int>( duration )` when player speed > 100. * This change therefore makes sure that all selected books are fully scanned when the activity is finished, regardless of number of calls to `do_turn()`. * The number of calls to `do_turn()` does not really matter anyway, it's just used for supporting that some books are fully scanned while the activity is running. * display selected proficiency when opening proficiency UI from character display * add more (zombie) leather mask variant (CleverRaven#69013) * Update masks.json * Update data/json/items/armor/masks.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix pharmacy and doctor's office loot (CleverRaven#68995) * what the fuck * Update science_and_tech.json * rare drugs * painkillers * antiseptic powder * [Xedra Evolved] Misc additions (CleverRaven#68931) * Initial commit * spell check fixes * Thank you Ferret Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com> * Update gunmods.json --------- Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com> * Adjust hungry and overweight coloring in sidebar (CleverRaven#69005) * Update hunger.json * Update weight.json * Update sidebar-mobile.json * Update hunger.json * Remove boat hull coverage penalty for protrusions and carried vehicles (CleverRaven#69024) * Remove penalty from protrusions and carried parts when calculating boat hull coverage * Fix possible uninitialized value in vehicle.cpp * Increase(?) water drag coefficients for land vehicles with protrusions * Remove trailing zeroes in drag test JSON * Organize the remaining unorganized EOCs (CleverRaven#68940) * Organize the stuff * Update FREQUENTLY_MADE_SUGGESTIONS.md * Revert "Update FREQUENTLY_MADE_SUGGESTIONS.md" This reverts commit 0ca0c05. * Update FREQUENTLY_MADE_SUGGESTIONS.md * Organize the lab eocs * Opps, rename * try to fix some weirdness with Github * Syntax fix Remove extra space in description string * Add a missing 'R' Fix flag misspelling * MOM Monster Overrides Replace 'mon_frog_mega' with new mega frog references for monster regeneration overrides in Mind Over Matter. * MOM Overrides Fix No pattern megafrog, no regen * Effect & Family Updates -Tune up and capitalize Electrocution effect. -Add physiology dissection proficiency family to all frog monsters to match CleverRaven#68760 * Pattern Frog Flavor Touch up description text for pattern frogs --------- Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com> Co-authored-by: gettingusedto <78019001+gettingusedto@users.noreply.github.com> Co-authored-by: LordBarkBread <97002254+LordBarkBread@users.noreply.github.com> Co-authored-by: Tim Nordenfur <tim@gurka.se> Co-authored-by: inogenous <123803852+inogenous@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: KeremBaba <rasitkeremgulgun@gmail.com> Co-authored-by: Anton Simakov <67688115+GuardianDll@users.noreply.github.com> Co-authored-by: Risuga <oosyrag@gmail.com> Co-authored-by: Evan Balster <evan@interactopia.com> Co-authored-by: MNG-cataclysm <58958654+MNG-cataclysm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
The proficiencies gained from corpse dissection are allocated inconsistently and do not always contribute to prerequisite proficiencies, while leaving you in the dark as to what these are.
Solution you would like.
Dissection of creatures falling into a group described by proficiencies would contribute to those proficies or, when prerequisites are missing, the next missing prerequisite proficiencie(s).
Edit: After finally finding (through json files) that biochemistry has chemistry as its prerequisite chain, I realize that makes sense for the proficiency itself, but it then doesn't make sense for it to be gained through dissection, but rather should be gained through study of dissection products (acids, what I've seen so far) via research/training recipes.
Describe alternatives you have considered.
Fumble around in the dark and accept it's a proficiency lottery.
Edit:
Retain biochemistry as a dissection gained proficiency where you analyze its properties while dissecting, rather than in a chemical examination environment, but then somehow indicate you need to study chemistry to gain the prerequisites, not dissecting lots of corpses.
Additional context
This is not a new issue...
The text was updated successfully, but these errors were encountered: