Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing wp proficiencies (part 4) #69292

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Adding missing proficiencies based on survey in comments on #68760.
This basically means adding basic biology and physiology to a range of critters that lacked them.

Describe the solution

Adding the "families" entries to the critters.

Describe alternatives you've considered

  • Won't touch natural armor due to a lack of understanding of where to draw the line between where it should and shouldn't be present.
  • Noted that power leech ought to have its own set of proficiencies and weakpoints. Left for another PR. Note that it would probably cause merge problems with this PR if this PR hasn't been merged before that one is produced.
  • Noted that robot type monsters ought to have its own set of proficiencies and weakpoints. Left for another PR.
  • Noted that slimes ought to have its own set of proficiencies and weakpoints. Left for another PR.
  • Noted that triffids ought to have its own set of proficiencies and weakpoints. Left for another PR.

Testing

Debug spawned one modified monster from each file, debug killed it, and verified the added proficiencies were present when bringing up the dissection butchery option.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 12, 2023
@Maleclypse Maleclypse merged commit 8d20d1d into CleverRaven:master Nov 12, 2023
@PatrikLundell PatrikLundell deleted the fix_wp_prof_4 branch November 12, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants