Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Physiology (Part 7/7) #69499

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Fix #68760 (this is the last PR, although number 6 hasn't been merged by the time of this writing).
Add Physiology to a lot of monsters lacking it.
Also added weakpoints and families to the gastro bufo which lacked them for some reason (didn't seem to have been the case while the comments for #68760 were produced?).

Describe the solution

Just stick the Physiology proficiency into the "families" entry of a lot of monsters.

Describe alternatives you've considered

Testing

Debug spawned and debug killed one monster from each modified file and verified it had the expected proficiencies listed when bringing up the dissection butcher entry for it.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 18, 2023
@TheSaddestGoomba
Copy link
Contributor

I think the gastro bufo may be because I only added physiology to the living amphibians in #68197

I just checked and it looks like it's missing from the other zombie frogs. Zombullfrog, colossal zombullfrog, and frog mother

@PatrikLundell PatrikLundell marked this pull request as draft November 18, 2023 17:49
@PatrikLundell
Copy link
Contributor Author

PatrikLundell commented Nov 18, 2023

Thanks. I'll take a look at the other zombie versions before I pull it out of the draft I just put the PR in.

OK, looks like the changes will have to go into the previous PR, which hasn't been accepted yet.

Edit: That PR has now been merged with those changes in it.

@PatrikLundell PatrikLundell marked this pull request as ready for review November 18, 2023 18:54
@Maleclypse Maleclypse merged commit 8af651c into CleverRaven:master Nov 21, 2023
@PatrikLundell PatrikLundell deleted the fix_wp_prof_7 branch November 13, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit monster dissection proficiency allocation
3 participants