[EASI-4473] Notification: Data Exchange Approach Completed #1209

OddTomBrooks · 2024-07-02T20:57:53Z

EASI-4473

Description

SQL Store methods
GQL
Added activity type
Unit test (activity)
Unit test (email)
Seeding test / email dispatch
Router helper function for integration with data exchange implementation

How to test this change

Validate unit tests by running scripts/dev test:go
Validate footers for email recipients and no footers for MINT Team email
Use Get Notification endpoint on Postman to validate Notification data

PR Author Checklist

I have provided a detailed description of the changes in this PR.
I have provided clear instructions on how to test the changes in this PR.
I have updated tests or written new tests as appropriate in this PR.
Updated the Postman Collection if necessary.

PR Reviewer Guidelines

It's best to pull the branch locally and test it, rather than just looking at the code online!
When approving a PR, provide a reason why you're approving it
- e.g. "Approving because I tested it locally and all functionality works as expected"
- e.g. "Approving because the change is simple and matches the Figma design"
Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

…ge approach in-app notification

…ferences

… to validate email templates

…nd work to EASI-4491

…ch_complete

…' of github.com:CMSgov/mint-app into feature/EASI-4473_notif_data_exchange_approach_complete

OddTomBrooks · 2024-07-07T05:51:43Z

Do not merge until frontend implementation is integrated into this PR

Failed tests are due to pending frontend implementation

pkg/graph/resolvers/user_notification_preferences.resolvers.go

pkg/models/data_exchange_approach.go

pkg/graph/schema/types/activity.graphql

pkg/models/data_exchange_approach_completed_activity_meta.go

pkg/graph/resolvers/data_exchange_approach_helper.go

MINT.postman_collection.json

pkg/notifications/data_exchange_approach_completed.go

StevenWadeOddball · 2024-07-09T19:05:49Z

I forgot to note! I also verified the email and it looks good, thanks @OddTomBrooks!

…fication preferences

…rences spec

…dCompleteBy

StevenWadeOddball

Thanks Tom, I added a couple notes about the notification that can be picked up when this is handled again. I don't think it makes sense to implement anything until the final designs are complete, but I wanted to note this feedback for when it is picked up again.

StevenWadeOddball · 2024-07-16T16:04:58Z

pkg/graph/schema/types/activity.graphql

 type DataExchangeApproachCompletedActivityMeta {
  version: Int!
  type: ActivityType!
-  dataExchangeApproach: DataExchangeApproach!
+  dataExchangeApproachID: UUID!


I think for this meta, we'd want both the ID, and the dataloader result to return the actually approach. Might be good to just add as a todo in the feature branch

(so that the front end can access the actual data if needed)

StevenWadeOddball · 2024-07-16T16:07:00Z

pkg/graph/resolvers/user_notification_preferences.resolvers.go

@@ -63,7 +62,7 @@ func (r *userNotificationPreferencesResolver) DatesChanged(ctx context.Context,

 // DataExchangeApproachCompleted is the resolver for the dataExchangeApproachCompleted field.
 func (r *userNotificationPreferencesResolver) DataExchangeApproachCompleted(ctx context.Context, obj *models.UserNotificationPreferences) ([]models.UserNotificationPreferenceFlag, error) {


This should probably get some attention when it is picked up again. I'm not sure why it should be creating a resolver instead of auto mapping... 🤔

StevenWadeOddball · 2024-07-16T16:09:18Z

pkg/models/data_exchange_approach_completed_activity_meta.go

-	DataExchangeApproach *DataExchangeApproach `json:"dataExchangeApproach"`
-	MarkedCompleteBy     uuid.UUID             `json:"markedCompleteBy"`
+	DataExchangeApproachID uuid.UUID `json:"dataExchangeApproachID"`
+	MarkedCompleteBy       uuid.UUID `json:"markedCompleteBy"`
 }


Note I think we probably want to the model_plan_id stored here too.

* feat: added feature migration, data models, gql * chore: updated sql queries * feat: several major improvements to first semi-functional data exchange approach in-app notification * chore: updated postman collection to get all notifications * chore: updated frontend gql and backend gql for user notification preferences * chore: added simple resolver helper to dispatch emails and email test to validate email templates * chore: removed resolved question * chore: Reset all frontend files to main branch as we split the frontend work to EASI-4491 * chore: reran gql gen * fix: forcing a commit for rebasing purposes * chore: removed tmp file * [EASI-4473] Notification: Data Exchange Approach Completed (#1209) * feat: added feature migration, data models, gql * chore: updated sql queries * feat: several major improvements to first semi-functional data exchange approach in-app notification * chore: updated postman collection to get all notifications * chore: updated frontend gql and backend gql for user notification preferences * chore: added simple resolver helper to dispatch emails and email test to validate email templates * chore: removed resolved question * chore: Reset all frontend files to main branch as we split the frontend work to EASI-4491 * chore: reran gql gen * chore: email unit test for data exchange approach completed * chore: removed unnecessary Scan and Value methods * chore: added unit test for activity data exchange complete notification * chore: implemented resolver for data exchange approach completed notification preferences * fix: updated various test definitions to match new user account preferences spec * chore: removed outdated comment * chore: updated postman collection renaming markedCompletedBy -> markedCompleteBy * chore: converted data exchange approach complete meta to id * chore: updated migration version * wip: data exchange approach * wip: data exchange approach gql, store, and resolvers * feat: working data exchange approach creation and updates * feat: several feedback elements implemented * chore: implementing PR feedback * chore: implementing PR feedback * wip: marked complete by user account and dts tracking * feat: first working version of plan data exchange approach * chore: ran linter and fixed cache helper reference * run eslint * fix: corrected cyclic dependency and several linter guidances * merging changes * ran sql fluff linter on migrations * run lint * fix: restructed logic for is marked complete to utilize null state of MarkedByDts rather than explicit boolean field * feat: added status handling * chore: corrected file name * chore: removed old debug print * fix: fixed lagging status * fix: added status to sql queries * fix: corrected enum references from COMPLETE to COMPELETED * chore: removed delete logic for dea * chore: refactored IsDataExchangeApproachComplete resolver * chore: updated enum to READY to conform more closely with other task list sections --------- Co-authored-by: ClayBenson94 <clay.benson@oddball.io> Co-authored-by: Steven Wade <steven.wade@oddball.io>

* feat: added feature migration, data models, gql * chore: updated sql queries * feat: several major improvements to first semi-functional data exchange approach in-app notification * chore: updated postman collection to get all notifications * chore: updated frontend gql and backend gql for user notification preferences * chore: added simple resolver helper to dispatch emails and email test to validate email templates * chore: removed resolved question * chore: Reset all frontend files to main branch as we split the frontend work to EASI-4491 * chore: reran gql gen * fix: forcing a commit for rebasing purposes * chore: removed tmp file * [EASI-4473] Notification: Data Exchange Approach Completed (#1209) * feat: added feature migration, data models, gql * chore: updated sql queries * feat: several major improvements to first semi-functional data exchange approach in-app notification * chore: updated postman collection to get all notifications * chore: updated frontend gql and backend gql for user notification preferences * chore: added simple resolver helper to dispatch emails and email test to validate email templates * chore: removed resolved question * chore: Reset all frontend files to main branch as we split the frontend work to EASI-4491 * chore: reran gql gen * chore: email unit test for data exchange approach completed * chore: removed unnecessary Scan and Value methods * chore: added unit test for activity data exchange complete notification * chore: implemented resolver for data exchange approach completed notification preferences * fix: updated various test definitions to match new user account preferences spec * chore: removed outdated comment * chore: updated postman collection renaming markedCompletedBy -> markedCompleteBy * chore: converted data exchange approach complete meta to id * chore: updated migration version * wip: data exchange approach * wip: data exchange approach gql, store, and resolvers * feat: working data exchange approach creation and updates * feat: several feedback elements implemented * chore: implementing PR feedback * chore: implementing PR feedback * wip: marked complete by user account and dts tracking * feat: first working version of plan data exchange approach * chore: ran linter and fixed cache helper reference * run eslint * fix: corrected cyclic dependency and several linter guidances * merging changes * ran sql fluff linter on migrations * run lint * fix: restructed logic for is marked complete to utilize null state of MarkedByDts rather than explicit boolean field * feat: added status handling * chore: corrected file name * chore: removed old debug print * fix: fixed lagging status * fix: added status to sql queries * Init dea query * fix: corrected enum references from COMPLETE to COMPELETED * Added card and translations * chore: removed delete logic for dea * chore: refactored IsDataExchangeApproachComplete resolver * chore: updated enum to READY to conform more closely with other task list sections * Added status enum change update * Added start approach button * Added unit test --------- Co-authored-by: Tom Brooks <tom.brooks@oddball.io> Co-authored-by: Tom Brooks <100007843+OddTomBrooks@users.noreply.github.com> Co-authored-by: ClayBenson94 <clay.benson@oddball.io> Co-authored-by: Steven Wade <steven.wade@oddball.io>

* feat: added feature migration, data models, gql * chore: updated sql queries * feat: several major improvements to first semi-functional data exchange approach in-app notification * chore: updated postman collection to get all notifications * chore: updated frontend gql and backend gql for user notification preferences * chore: added simple resolver helper to dispatch emails and email test to validate email templates * chore: removed resolved question * chore: Reset all frontend files to main branch as we split the frontend work to EASI-4491 * chore: reran gql gen * fix: forcing a commit for rebasing purposes * chore: removed tmp file * [EASI-4473] Notification: Data Exchange Approach Completed (#1209) * feat: added feature migration, data models, gql * chore: updated sql queries * feat: several major improvements to first semi-functional data exchange approach in-app notification * chore: updated postman collection to get all notifications * chore: updated frontend gql and backend gql for user notification preferences * chore: added simple resolver helper to dispatch emails and email test to validate email templates * chore: removed resolved question * chore: Reset all frontend files to main branch as we split the frontend work to EASI-4491 * chore: reran gql gen * chore: email unit test for data exchange approach completed * chore: removed unnecessary Scan and Value methods * chore: added unit test for activity data exchange complete notification * chore: implemented resolver for data exchange approach completed notification preferences * fix: updated various test definitions to match new user account preferences spec * chore: removed outdated comment * chore: updated postman collection renaming markedCompletedBy -> markedCompleteBy * chore: converted data exchange approach complete meta to id * chore: updated migration version * wip: data exchange approach * wip: data exchange approach gql, store, and resolvers * feat: working data exchange approach creation and updates * feat: several feedback elements implemented * chore: implementing PR feedback * chore: implementing PR feedback * wip: marked complete by user account and dts tracking * feat: first working version of plan data exchange approach * chore: ran linter and fixed cache helper reference * run eslint * fix: corrected cyclic dependency and several linter guidances * merging changes * ran sql fluff linter on migrations * run lint * fix: restructed logic for is marked complete to utilize null state of MarkedByDts rather than explicit boolean field * feat: added status handling * chore: corrected file name * chore: removed old debug print * fix: fixed lagging status * fix: added status to sql queries * fix: corrected enum references from COMPLETE to COMPELETED * chore: removed delete logic for dea * chore: refactored IsDataExchangeApproachComplete resolver * chore: updated enum to READY to conform more closely with other task list sections * feat: email notification for plan data exchange approach marked complete * fix: corrected ID from existing DEA to model ID * chore: updated postman collection * chore: simplified store method per PR feedback * chore: getting model plan using loader per PR review * fix: corrected accidentally switched footers * fix: corrected id assignment in notification metadata * fix: referencing UTC Now cache var in test * chore: PR feedback * chore: PR feedback * chore: PR feedback * chore: fix tx usage for rollback * chore: PR feedback * Update data exchange notification logic to only attempt to send if email services are non-nil * chore: PR feedback to remove redundant DISTINCT call * chore: PR feedback to send batch emails by BCC * Update postman collection with ability to update notification preferences for data Exchange --------- Co-authored-by: ClayBenson94 <clay.benson@oddball.io> Co-authored-by: Steven Wade <steven.wade@oddball.io>

OddTomBrooks and others added 12 commits July 2, 2024 14:54

feat: added feature migration, data models, gql

d5928f8

chore: updated sql queries

c82e948

feat: several major improvements to first semi-functional data exchan…

a3600a7

…ge approach in-app notification

chore: updated postman collection to get all notifications

aee9a0f

chore: updated frontend gql and backend gql for user notification pre…

d01f101

…ferences

chore: added simple resolver helper to dispatch emails and email test…

d52fdee

… to validate email templates

chore: removed resolved question

db22226

chore: Reset all frontend files to main branch as we split the fronte…

a8dab47

…nd work to EASI-4491

chore: reran gql gen

58a62c2

Merge branch 'main' into feature/EASI-4473_notif_data_exchange_approa…

ac4cb5b

…ch_complete

chore: email unit test for data exchange approach completed

a86a8c9

Merge branch 'feature/EASI-4473_notif_data_exchange_approach_complete…

d97ab3c

…' of github.com:CMSgov/mint-app into feature/EASI-4473_notif_data_exchange_approach_complete

OddTomBrooks marked this pull request as ready for review July 7, 2024 05:47

OddTomBrooks requested review from a team as code owners July 7, 2024 05:47

OddTomBrooks requested review from StevenWadeOddball and patrickseguraoddball and removed request for a team July 7, 2024 05:47

OddTomBrooks added blocked do not merge labels Jul 7, 2024

StevenWadeOddball requested a review from ClayBenson94 July 9, 2024 13:29

StevenWadeOddball requested changes Jul 9, 2024

View reviewed changes

OddTomBrooks added 4 commits July 10, 2024 18:57

chore: removed unnecessary Scan and Value methods

2e81438

chore: added unit test for activity data exchange complete notification

834c34d

chore: implemented resolver for data exchange approach completed noti…

e401f1d

…fication preferences

fix: updated various test definitions to match new user account prefe…

52ceb84

…rences spec

OddTomBrooks changed the base branch from main to NOREF/data_exchange_approach July 12, 2024 03:46

chore: removed outdated comment

8a9d37c

OddTomBrooks removed blocked do not merge labels Jul 12, 2024

OddTomBrooks added 2 commits July 12, 2024 00:30

chore: updated postman collection renaming markedCompletedBy -> marke…

2e42900

…dCompleteBy

chore: converted data exchange approach complete meta to id

cff7c48

OddTomBrooks merged commit 3d4e8b1 into NOREF/data_exchange_approach Jul 16, 2024
8 of 11 checks passed

OddTomBrooks deleted the feature/EASI-4473_notif_data_exchange_approach_complete branch July 16, 2024 09:47

StevenWadeOddball reviewed Jul 16, 2024

View reviewed changes

StevenWadeOddball mentioned this pull request Jul 16, 2024

[NOREF] Data Exchange Approach and Data Exchange Approach Complete Notification #1227

Closed

4 tasks

StevenWadeOddball added a commit that referenced this pull request Jul 17, 2024

fix: add todo comments from PR review #1209 (review)

cf6edea

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[EASI-4473] Notification: Data Exchange Approach Completed #1209

[EASI-4473] Notification: Data Exchange Approach Completed #1209

OddTomBrooks commented Jul 2, 2024 •

edited

Loading

OddTomBrooks commented Jul 7, 2024

StevenWadeOddball commented Jul 9, 2024

StevenWadeOddball left a comment

StevenWadeOddball Jul 16, 2024

StevenWadeOddball Jul 16, 2024

StevenWadeOddball Jul 16, 2024

StevenWadeOddball Jul 16, 2024

		@@ -63,7 +62,7 @@ func (r *userNotificationPreferencesResolver) DatesChanged(ctx context.Context,

		// DataExchangeApproachCompleted is the resolver for the dataExchangeApproachCompleted field.
		func (r userNotificationPreferencesResolver) DataExchangeApproachCompleted(ctx context.Context, obj models.UserNotificationPreferences) ([]models.UserNotificationPreferenceFlag, error) {

[EASI-4473] Notification: Data Exchange Approach Completed #1209

[EASI-4473] Notification: Data Exchange Approach Completed #1209

Conversation

OddTomBrooks commented Jul 2, 2024 • edited Loading

EASI-4473

Description

How to test this change

PR Author Checklist

PR Reviewer Guidelines

OddTomBrooks commented Jul 7, 2024

StevenWadeOddball commented Jul 9, 2024

StevenWadeOddball left a comment

Choose a reason for hiding this comment

StevenWadeOddball Jul 16, 2024

Choose a reason for hiding this comment

StevenWadeOddball Jul 16, 2024

Choose a reason for hiding this comment

StevenWadeOddball Jul 16, 2024

Choose a reason for hiding this comment

StevenWadeOddball Jul 16, 2024

Choose a reason for hiding this comment

OddTomBrooks commented Jul 2, 2024 •

edited

Loading