[MINT-2550] Data Exchange Approach Marked Complete Notification #1403

OddTomBrooks · 2024-10-07T18:01:05Z

MINT-2550

Description

Added notification for when Data Exchange Approach is marked complete

How to test this change

Open Postman
Create a model plan
Set the Post Man user account notification preference flags to include both EMAIL and IN_APP (I do this directly in the database)
Update the Data Exchange Approach section
Upon setting the Marked Complete bool to true, you should see an email in Mailcatcher and a should be able to see an in-app notification by getting the user's notifications in postman

PR Author Checklist

I have provided a detailed description of the changes in this PR.
I have provided clear instructions on how to test the changes in this PR.
I have updated tests or written new tests as appropriate in this PR.
Updated the Postman Collection if necessary.

PR Reviewer Guidelines

It's best to pull the branch locally and test it, rather than just looking at the code online!
When approving a PR, provide a reason why you're approving it
- e.g. "Approving because I tested it locally and all functionality works as expected"
- e.g. "Approving because the change is simple and matches the Figma design"
Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

…ge approach in-app notification

…ferences

… to validate email templates

…nd work to EASI-4491

* feat: added feature migration, data models, gql * chore: updated sql queries * feat: several major improvements to first semi-functional data exchange approach in-app notification * chore: updated postman collection to get all notifications * chore: updated frontend gql and backend gql for user notification preferences * chore: added simple resolver helper to dispatch emails and email test to validate email templates * chore: removed resolved question * chore: Reset all frontend files to main branch as we split the frontend work to EASI-4491 * chore: reran gql gen * chore: email unit test for data exchange approach completed * chore: removed unnecessary Scan and Value methods * chore: added unit test for activity data exchange complete notification * chore: implemented resolver for data exchange approach completed notification preferences * fix: updated various test definitions to match new user account preferences spec * chore: removed outdated comment * chore: updated postman collection renaming markedCompletedBy -> markedCompleteBy * chore: converted data exchange approach complete meta to id

# Conflicts: # cmd/dbseed/main.go # cmd/test_email/main.go # pkg/email/template_service_impl.go # pkg/graph/generated/generated.go # src/gql/gen/graphql.ts

…ta_exchange_approach # Conflicts: # MINT.postman_collection.json # cmd/dbseed/main.go # cmd/test_email/main.go # pkg/email/template_service_impl.go # pkg/graph/generated/generated.go # pkg/graph/resolvers/activity.resolvers.go # pkg/graph/resolvers/added_as_collaborator_email_test.go # pkg/graph/resolvers/data_exchange_approach_helper.go # pkg/graph/resolvers/plan_collaborator_test.go # pkg/graph/resolvers/resolver_test.go # pkg/graph/resolvers/resolver_test_utilities.go # pkg/graph/resolvers/user_notification_preferences.resolvers.go # pkg/graph/schema/types/activity.graphql # pkg/models/data_exchange_approach.go # pkg/models/data_exchange_approach_completed_activity_meta.go # pkg/notifications/data_exchange_approach_completed.go # src/gql/gen/graphql.ts

# Conflicts: # pkg/graph/generated/generated.go

…:CMSgov/mint-app into feature/MINT-2720_data_exchange_approach

ClayBenson94

I think the A.C. for the user being able to select which models they get a notification for isn't quite accounted for from what I can see

This should probably just follow the same pattern that we did for the "Dates Changed" email (migration here)

You could probably even just re-use/rename that type to something like MODEL_NOTIFICATION_SELECTION_TYPE or something like that since both use the same type of dropdown.

StevenWadeOddball

Thanks Tom, I tested your existing functionality and confirmed I received emails and notifications. I agree with Clay's note about needing to specify which models to receive notifications.

Most of the feedback I've provided is in regards to implementing some standard paradigms for store methods, and a few about data instantiation. Please let me know if you have any questions.

pkg/storage/user_accountStore.go

MINT.postman_collection.json

pkg/graph/resolvers/plan_data_exchange_approach.go

pkg/storage/plan_data_exchange_approachStore.go

pkg/models/plan_data_exchange_approach_completed_activity_meta.go

pkg/graph/resolvers/activity.resolvers.go

pkg/storage/plan_data_exchange_approachStore.go

cmd/dbseed/main.go

…ail services are non-nil

StevenWadeOddball

Thanks Tom, this looks good. There are just a couple things I noticed that I'd appreciate you taking a look at and responding to / or updating. Thanks!

pkg/graph/resolvers/plan_data_exchange_approach.go

...ies/SQL/user_account/get_notification_preferences_data_exchange_approach_marked_complete.sql

pkg/graph/resolvers/plan_data_exchange_approach_helper.go

pkg/graph/resolvers/plan_data_exchange_approach.go

pkg/graph/resolvers/plan_data_exchange_approach_test.go

migrations/V177__Add_Data_Exchange_Approach_Marked_Complete_Notification.sql

… into task/MINT-2550_dea_notif

PTO

…a_notif # Conflicts: # pkg/graph/resolvers/plan_data_exchange_approach_test.go

…nces for data Exchange

…a_notif

OddTomBrooks and others added 30 commits July 5, 2024 02:07

feat: added feature migration, data models, gql

742589f

chore: updated sql queries

eed69df

feat: several major improvements to first semi-functional data exchan…

729ce45

…ge approach in-app notification

chore: updated postman collection to get all notifications

343a984

chore: updated frontend gql and backend gql for user notification pre…

58ab8f4

…ferences

chore: added simple resolver helper to dispatch emails and email test…

0706fae

… to validate email templates

chore: removed resolved question

95f07f9

chore: Reset all frontend files to main branch as we split the fronte…

54daae0

…nd work to EASI-4491

chore: reran gql gen

d113b08

fix: forcing a commit for rebasing purposes

6395210

chore: removed tmp file

9d4d41c

Merge branch 'main' into feature/MINT-2720_data_exchange_approach

c1412b7

# Conflicts: # cmd/dbseed/main.go # cmd/test_email/main.go # pkg/email/template_service_impl.go # pkg/graph/generated/generated.go # src/gql/gen/graphql.ts

chore: updated migration version

2c829f4

wip: data exchange approach

6c72a54

wip: data exchange approach gql, store, and resolvers

6084f0a

feat: working data exchange approach creation and updates

ade1e73

feat: several feedback elements implemented

7ec9c2a

chore: implementing PR feedback

1b03e5f

chore: implementing PR feedback

5bc49a9

wip: marked complete by user account and dts tracking

13ebcf1

feat: first working version of plan data exchange approach

ae1095d

Merge branch 'main' into feature/MINT-2720_data_exchange_approach

6297312

# Conflicts: # pkg/graph/generated/generated.go

chore: ran linter and fixed cache helper reference

5b11b33

run eslint

e6ce2e5

fix: corrected cyclic dependency and several linter guidances

058e8aa

Merge branch 'feature/MINT-2720_data_exchange_approach' of github.com…

a53d106

…:CMSgov/mint-app into feature/MINT-2720_data_exchange_approach

merging changes

0b9ad42

ran sql fluff linter on migrations

b3a1c47

StevenWadeOddball changed the base branch from main to feature/MINT-2720_data_exchange October 7, 2024 20:14

ClayBenson94 requested changes Oct 8, 2024

View reviewed changes

StevenWadeOddball requested changes Oct 8, 2024

View reviewed changes

OddTomBrooks added 9 commits October 8, 2024 11:18

manual merge

d8df549

chore: simplified store method per PR feedback

7cff784

chore: getting model plan using loader per PR review

a65bf54

fix: corrected accidentally switched footers

ce0d251

fix: corrected id assignment in notification metadata

6a0835a

fix: referencing UTC Now cache var in test

db1ae1a

chore: PR feedback

e05f7e9

chore: PR feedback

5a53fc9

chore: PR feedback

bb4ac22

OddTomBrooks requested review from StevenWadeOddball and ClayBenson94 October 10, 2024 19:09

OddTomBrooks and others added 4 commits October 11, 2024 00:46

chore: fix tx usage for rollback

d825193

chore: PR feedback

607f753

Merge feature

e370e3b

Update data exchange notification logic to only attempt to send if em…

190cea3

…ail services are non-nil

StevenWadeOddball previously requested changes Oct 11, 2024

View reviewed changes

OddTomBrooks added 3 commits October 14, 2024 10:04

chore: PR feedback to remove redundant DISTINCT call

5a011d0

Merge branch 'task/MINT-2550_dea_notif' of github.com:CMSgov/mint-app…

2b8f0ac

… into task/MINT-2550_dea_notif

chore: PR feedback to send batch emails by BCC

9df42df

OddTomBrooks and others added 5 commits October 14, 2024 13:12

Merge branch 'feature/MINT-2720_data_exchange' into task/MINT-2550_de…

4ed9435

…a_notif # Conflicts: # pkg/graph/resolvers/plan_data_exchange_approach_test.go

Update postman collection with ability to update notification prefere…

219009d

…nces for data Exchange

Merge branch 'feature/MINT-2720_data_exchange' into task/MINT-2550_de…

1d3a4c3

…a_notif

Merge branch 'feature/MINT-2720_data_exchange' into task/MINT-2550_de…

6735eed

…a_notif

Merge branch 'feature/MINT-2720_data_exchange' into task/MINT-2550_de…

97e3cb3

…a_notif

OddTomBrooks merged commit 02a23ac into feature/MINT-2720_data_exchange Oct 15, 2024
7 of 11 checks passed

OddTomBrooks deleted the task/MINT-2550_dea_notif branch October 15, 2024 12:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MINT-2550] Data Exchange Approach Marked Complete Notification #1403

[MINT-2550] Data Exchange Approach Marked Complete Notification #1403

OddTomBrooks commented Oct 7, 2024 •

edited

Loading

ClayBenson94 left a comment

StevenWadeOddball left a comment

StevenWadeOddball left a comment

[MINT-2550] Data Exchange Approach Marked Complete Notification #1403

[MINT-2550] Data Exchange Approach Marked Complete Notification #1403

Conversation

OddTomBrooks commented Oct 7, 2024 • edited Loading

MINT-2550

Description

How to test this change

PR Author Checklist

PR Reviewer Guidelines

ClayBenson94 left a comment

Choose a reason for hiding this comment

StevenWadeOddball left a comment

Choose a reason for hiding this comment

StevenWadeOddball left a comment

Choose a reason for hiding this comment

OddTomBrooks commented Oct 7, 2024 •

edited

Loading