Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NOREF] Data Exchange Approach and Data Exchange Approach Complete Notification #1227

Closed
wants to merge 1 commit into from
Closed

[NOREF] Data Exchange Approach and Data Exchange Approach Complete Notification #1227

wants to merge 1 commit into from

Conversation

OddTomBrooks
Copy link
Contributor

EASI-4473

Description

  • SQL Store methods
  • GQL
  • Added activity type
  • Unit test (activity)
  • Unit test (email)
  • Seeding test / email dispatch
  • Router helper function for integration with data exchange implementation

How to test this change

  • Validate unit tests by running scripts/dev test:go
  • Validate footers for email recipients and no footers for MINT Team email
  • Use Get Notification endpoint on Postman to validate Notification data

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@OddTomBrooks
[EASI-4473] Notification: Data Exchange Approach Completed (#1209)
3d4e8b1 
* feat: added feature migration, data models, gql

* chore: updated sql queries

* feat: several major improvements to first semi-functional data exchange approach in-app notification

* chore: updated postman collection to get all notifications

* chore: updated frontend gql and backend gql for user notification preferences

* chore: added simple resolver helper to dispatch emails and email test to validate email templates

* chore: removed resolved question

* chore: Reset all frontend files to main branch as we split the frontend work to EASI-4491

* chore: reran gql gen

* chore: email unit test for data exchange approach completed

* chore: removed unnecessary Scan and Value methods

* chore: added unit test for activity data exchange complete notification

* chore: implemented resolver for data exchange approach completed notification preferences

* fix: updated various test definitions to match new user account preferences spec

* chore: removed outdated comment

* chore: updated postman collection renaming markedCompletedBy -> markedCompleteBy

* chore: converted data exchange approach complete meta to id
@StevenWadeOddball
Copy link
Contributor

Thanks @OddTomBrooks , I added a few notes about the notification in the original PR. These are not meant to cause immediate action, but just some things to consider when this work is picked up again. Review comments can be viewed here

@OddTomBrooks
Copy link
Contributor Author

Closing temporarily until Prod/UX is ready for this work to be revisited

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OddTomBrooks @StevenWadeOddball