-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINT-2720] Data Exchange Approach #1380
[MINT-2720] Data Exchange Approach #1380
Conversation
…ge approach in-app notification
… to validate email templates
* feat: added feature migration, data models, gql * chore: updated sql queries * feat: several major improvements to first semi-functional data exchange approach in-app notification * chore: updated postman collection to get all notifications * chore: updated frontend gql and backend gql for user notification preferences * chore: added simple resolver helper to dispatch emails and email test to validate email templates * chore: removed resolved question * chore: Reset all frontend files to main branch as we split the frontend work to EASI-4491 * chore: reran gql gen * chore: email unit test for data exchange approach completed * chore: removed unnecessary Scan and Value methods * chore: added unit test for activity data exchange complete notification * chore: implemented resolver for data exchange approach completed notification preferences * fix: updated various test definitions to match new user account preferences spec * chore: removed outdated comment * chore: updated postman collection renaming markedCompletedBy -> markedCompleteBy * chore: converted data exchange approach complete meta to id
# Conflicts: # cmd/dbseed/main.go # cmd/test_email/main.go # pkg/email/template_service_impl.go # pkg/graph/generated/generated.go # src/gql/gen/graphql.ts
…ta_exchange_approach # Conflicts: # MINT.postman_collection.json # cmd/dbseed/main.go # cmd/test_email/main.go # pkg/email/template_service_impl.go # pkg/graph/generated/generated.go # pkg/graph/resolvers/activity.resolvers.go # pkg/graph/resolvers/added_as_collaborator_email_test.go # pkg/graph/resolvers/data_exchange_approach_helper.go # pkg/graph/resolvers/plan_collaborator_test.go # pkg/graph/resolvers/resolver_test.go # pkg/graph/resolvers/resolver_test_utilities.go # pkg/graph/resolvers/user_notification_preferences.resolvers.go # pkg/graph/schema/types/activity.graphql # pkg/models/data_exchange_approach.go # pkg/models/data_exchange_approach_completed_activity_meta.go # pkg/notifications/data_exchange_approach_completed.go # src/gql/gen/graphql.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tom, this is just a high level review of the data type in graphql. There is some deviation from FIGMA that I wanted to call out now instead of waiting till the PR is promoted.
… MarkedByDts rather than explicit boolean field
…:CMSgov/mint-app into feature/MINT-2720_data_exchange_approach # Conflicts: # migrations/V176__Add_Data_Exchange_Approach.sql
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting this error when creating a model plan and trying to query status
{
"errors": [
{
"message": "the requested element is null which the schema does not allow",
"path": [
"modelPlan",
"dataExchangeApproach",
"status"
]
}
],
"data": null
}
@OddTomBrooks can you add a EDIT: Wait, that's already there. Not sure why this'd come back EDIT 2: Looks like we might need to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tom, I think this is in a good state to merge to a feature branch. There are some thing that I think can be updated, but I think it would be better to merge this, and iterate on another PR.
I'd like to revisit the core struct before this targets main. I left a comment for a few other things I noticed, but as I don't think they will affect the front end, I think they can be addressed later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A note in case this file gets touched again, we have sqlutils.Get and Select procedures to handle most of the boilerplate for database calls. It can replace much of the existing code to prepare named statements here.
changes made
efc5617
into
feature/MINT-2720_data_exchange
MINT-2720
Description
Created Data Exchange Approach in accordance with Figma spec.
How to test this change
PR Author Checklist
PR Reviewer Guidelines