Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR] monitor/resource-manager #2460

Merged
merged 8 commits into from
Jun 6, 2018

Conversation

AutorestCI
Copy link
Contributor

Created to accumulate context: monitor/resource-manager

@AutorestCI
Copy link
Contributor Author

AutorestCI commented Apr 24, 2018

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-monitor

You can install the package azure-mgmt-monitor of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_monitor/resource-manager#egg=azure-mgmt-monitor&subdirectory=azure-mgmt-monitor"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_monitor/resource-manager#egg=azure-mgmt-monitor&subdirectory=azure-mgmt-monitor"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_monitor/resource-manager
  • pip install -e ./azure-mgmt-monitor

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_monitor/resource-manager
  • pip wheel --no-deps ./azure-mgmt-monitor

Direct download

Your files can be directly downloaded here:

@codecov-io
Copy link

codecov-io commented May 3, 2018

Codecov Report

Merging #2460 into master will decrease coverage by 0.47%.
The diff coverage is 44.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2460      +/-   ##
==========================================
- Coverage   55.95%   55.48%   -0.48%     
==========================================
  Files        7164     7629     +465     
  Lines      150814   171812   +20998     
==========================================
+ Hits        84395    95325   +10930     
- Misses      66419    76487   +10068
Impacted Files Coverage Δ
...azure/mgmt/monitor/models/action_group_resource.py 29.41% <0%> (-6.31%) ⬇️
...-monitor/azure/mgmt/monitor/operations/__init__.py 100% <100%> (ø) ⬆️
...ure/mgmt/monitor/models/rule_webhook_action_py3.py 55.55% <100%> (ø) ⬆️
.../monitor/models/activity_log_alert_resource_py3.py 45.45% <100%> (ø) ⬆️
...ure/mgmt/monitor/models/alert_rule_resource_py3.py 100% <100%> (ø) ⬆️
...gmt/monitor/operations/action_groups_operations.py 16.77% <100%> (ø) ⬆️
...odels/diagnostic_settings_category_resource_py3.py 71.42% <100%> (ø) ⬆️
azure-mgmt-monitor/azure/mgmt/monitor/version.py 100% <100%> (ø) ⬆️
...gmt/monitor/models/threshold_rule_condition_py3.py 100% <100%> (ø) ⬆️
...mgmt-monitor/azure/mgmt/monitor/models/__init__.py 100% <100%> (ø) ⬆️
... and 1193 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b0b19d...2d010c0. Read the comment docs.

@lmazuel
Copy link
Member

lmazuel commented Jun 6, 2018

@AutorestCI rebuild https://github.com/Azure/azure-rest-api-specs/blob/master/specification/monitor/resource-manager/readme.md

@AutorestCI
Copy link
Contributor Author

Build SDK finished and cleaned

@lmazuel
Copy link
Member

lmazuel commented Jun 6, 2018

@AutorestCI rebase

…Query Rule (#2416)

* Generated from d183bad923d3a0a4092d21203f850db6cde9f4e9

Resolving Comments

Resolving Comments

* Generated from df40ac3bbf17ea0180dd4adff2af3094065feca0

Made SKU as top level proprty and including generic error response format

Couple of changes -
1. Made SKU as top level proprty as mentioned here - https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/resource-api-reference.md#put-resource
 2. including generic error response format

* Generated from 7578160670750a68d05f77ec8163b25bb72f391e

Minor Changes to align implementation

1. Removed SKU - Billing Model is still under discussion, hence need not to be exposed to customers.
2.  Enabled field ichanged to align with camel case.
3.  'throttleTillDate' in properties.action changed to 'throttlingInMin' to denote correct meaning  and it’s data type changed to number instead of date.
4. 'status' to be removed in properties.action from examples.
5.  'severity' made a required field in properties.action.
6. Removed Examples from original spec json

* Generated from fb180fb311d73934d0f5150f72638cc3de155ea0

Added Default Response payload in all APIs

Changes -
1. Added Default Response payload in all APIs
2. Made azNs description more clear

* Generated from fb180fb311d73934d0f5150f72638cc3de155ea0

Added Default Response payload in all APIs

Changes -
1. Added Default Response payload in all APIs
2. Made azNs description more clear
…2513)

* Generated from 0c826790271a1be2d4af5905ee0eb089b4260feb

Merge pull request #1 from abversqr/MinorUpdates

Minor updates

* Generated from 1610a74a5c49c73a546972daca1e7a43798a8cea

Merge branch 'master' into master
…API spec for 2018-03-01 (#2592)

* Generated from d5b9b4545a8d15c70d3c8318d39e2f7b43229387

AutoMitigate changes

* Generated from d5b9b4545a8d15c70d3c8318d39e2f7b43229387

AutoMitigate changes
…in MetricAlert (#2617)

* Generated from 35adc5e493c20a57e6e2cb35d87c578133d2b7a6

[Monitor] Deconflict "Action" name in MetricAlert

Generates bad SDK.

* Generated from ebfaf0bdd7f2bcf736598d8ec501f490a83d1268

Update reference to MetricAlertAction
…2596)

* Generated from f53526896e5c001f79bd46ca892f825172b53abf

Merge branch 'master' into patchsupport

* Generated from f53526896e5c001f79bd46ca892f825172b53abf

Merge branch 'master' into patchsupport

* Generated from b37d3ace14508e3bc3f87ee29b7f2ad0b7025f67

Resolving multiple model issue

Changes - 
1. Renamed "MetricTrigger" to "LogMetricTrigger"
2. Aligned "Resources" to other specs
@AutorestCI
Copy link
Contributor Author

Rebase done and pushed to the branch

@AutorestCI AutorestCI force-pushed the restapi_auto_monitor/resource-manager branch from c908b86 to 026a4e1 Compare June 6, 2018 22:12
@lmazuel lmazuel merged commit fb6d5da into master Jun 6, 2018
@lmazuel lmazuel deleted the restapi_auto_monitor/resource-manager branch June 6, 2018 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants