Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates #2997

Closed
wants to merge 10 commits into from
Closed

Minor updates #2997

wants to merge 10 commits into from

Conversation

abversqr
Copy link
Member

@abversqr abversqr commented May 2, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

abversqr added 10 commits April 12, 2018 16:43
Added GA API version for Scheduled Query Rule
Resolving Comments
…rmat

Couple of changes -
1. Made SKU as top level proprty as mentioned here - https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/resource-api-reference.md#put-resource
 2. including generic error response format
1. Removed SKU - Billing Model is still under discussion, hence need not to be exposed to customers.
2.  Enabled field ichanged to align with camel case.
3.  'throttleTillDate' in properties.action changed to 'throttlingInMin' to denote correct meaning  and it’s data type changed to number instead of date.
4. 'status' to be removed in properties.action from examples.
5.  'severity' made a required field in properties.action.
6. Removed Examples from original spec json
Updated Example to reflect AI instances in tags and 'dataSourceId"
Restore Tags Description
Fixed errores reported by running command "oav validate-example"
Changes -
1. Added Default Response payload in all APIs
2. Made azNs description more clear
Updating descriptions + property name change
@AutorestCI
Copy link

AutorestCI commented May 2, 2018

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2460

@AutorestCI
Copy link

AutorestCI commented May 2, 2018

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#2602

@AutorestCI
Copy link

AutorestCI commented May 2, 2018

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
AutorestCI/azure-libraries-for-java#31

@AutorestCI
Copy link

AutorestCI commented May 2, 2018

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#1763

@abversqr
Copy link
Member Author

abversqr commented May 2, 2018

Will send seprate PR for changes, showing all changes.,

@abversqr abversqr closed this May 2, 2018
@abversqr abversqr deleted the MinorUpdates branch May 2, 2018 06:51
@abversqr abversqr restored the MinorUpdates branch May 2, 2018 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants