-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitor] Deconflict "Action" name in MetricAlert #3128
Conversation
Generates bad SDK.
cc @LeoVannelli |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-libraries-for-javaThe initial PR has been merged into your service PR: |
@@ -597,7 +597,7 @@ | |||
"x-ms-azure-resource": true, | |||
"description": "An azure resource object" | |||
}, | |||
"Action": { | |||
"MetricAlertAction": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update all references to /Action
and fix the syntax errors in CI
Automation for azure-sdk-for-rubyEncountered a Subprocess error: (azure-sdk-for-ruby)
Command: ['/usr/local/bin/autorest', '/tmp/tmps0c5m31j/rest/specification/monitor/resource-manager/readme.md', '--multiapi', '--ruby', '--ruby-sdks-folder=/tmp/tmps0c5m31j/sdk', '--use=@microsoft.azure/autorest.ruby@3.0.20', '--version=preview'] AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/root/.autorest/@microsoft.azure_autorest-core@2.0.4279/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4279)
Loading AutoRest extension '@microsoft.azure/autorest.ruby' (3.0.20->3.0.20)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.1.22->2.1.22)
Processing batch task - {"tag":"package-2015-04-01-only"} .
Processing batch task - {"tag":"package-2016-03-01-only"} .
Processing batch task - {"tag":"package-2016-09-01-only"} .
ERROR (Fatal/DuplicateParameterCollision): Duplicated global non-identical parameter definitions
- file:///tmp/tmps0c5m31j/rest/specification/monitor/resource-manager/microsoft.insights/stable/2016-09-01/serviceDiagnosticsSettings_API.json:395:4 ($.parameters.ResourceUriParameter)
- file:///tmp/tmps0c5m31j/rest/specification/monitor/resource-manager/microsoft.insights/stable/2016-09-01/metrics_API.json:269:4 ($.parameters.ResourceUriParameter)
Process() cancelled due to exception : Cancellation requested.
Failure during batch task - {"tag":"package-2016-09-01-only"} -- Cancellation requested..
Cancellation requested. |
Automation for azure-sdk-for-pythonEncountered a Subprocess error: (azure-sdk-for-python)
Command: ['/usr/local/bin/autorest', '/tmp/tmpab9gbj25/rest/specification/monitor/resource-manager/readme.md', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpab9gbj25/sdk', '--use=@microsoft.azure/autorest.python@~3.0', '--version=preview'] AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/root/.autorest/@microsoft.azure_autorest-core@2.0.4279/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4279)
Loading AutoRest extension '@microsoft.azure/autorest.python' (~3.0->3.0.51)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmpab9gbj25/rest/specification/monitor/resource-manager/microsoft.insights/stable/2018-04-16/scheduledQueryRule_API.json:255:4 ($.definitions.Resource)
- file:///tmp/tmpab9gbj25/rest/specification/monitor/resource-manager/microsoft.insights/stable/2018-03-01/metricAlert_API.json:562:4 ($.definitions.Resource)
- file:///tmp/tmpab9gbj25/rest/specification/monitor/resource-manager/microsoft.insights/stable/2017-04-01/activityLogAlerts_API.json:290:8 ($.definitions.Resource)
- file:///tmp/tmpab9gbj25/rest/specification/monitor/resource-manager/microsoft.insights/stable/2018-03-01/actionGroups_API.json:338:8 ($.definitions.Resource)
- file:///tmp/tmpab9gbj25/rest/specification/monitor/resource-manager/microsoft.insights/stable/2016-03-01/logProfiles_API.json:264:4 ($.definitions.Resource)
- file:///tmp/tmpab9gbj25/rest/specification/monitor/resource-manager/microsoft.insights/stable/2016-03-01/alertRules_API.json:791:4 ($.definitions.Resource)
- file:///tmp/tmpab9gbj25/rest/specification/monitor/resource-manager/microsoft.insights/stable/2015-04-01/autoscale_API.json:840:4 ($.definitions.Resource)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmpab9gbj25/rest/specification/monitor/resource-manager/microsoft.insights/stable/2018-04-16/scheduledQueryRule_API.json:413:4 ($.definitions.MetricTrigger)
- file:///tmp/tmpab9gbj25/rest/specification/monitor/resource-manager/microsoft.insights/stable/2015-04-01/autoscale_API.json:900:4 ($.definitions.MetricTrigger)
Process() cancelled due to exception : Cancellation requested.
Cancellation requested. |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
LGTM |
Generates bad SDK.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger