Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitor] Deconflict "Action" name in MetricAlert #3128

Merged
merged 2 commits into from
May 24, 2018

Conversation

tjprescott
Copy link
Member

@tjprescott tjprescott commented May 23, 2018

Generates bad SDK.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • [N/A] If applicable, the PR references the bug/issue that it fixes.
  • [N/A] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@tjprescott
Copy link
Member Author

cc @LeoVannelli

@AutorestCI
Copy link

AutorestCI commented May 23, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2602

@AutorestCI
Copy link

AutorestCI commented May 23, 2018

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#31

@@ -597,7 +597,7 @@
"x-ms-azure-resource": true,
"description": "An azure resource object"
},
"Action": {
"MetricAlertAction": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update all references to /Action and fix the syntax errors in CI

@AutorestCI
Copy link

AutorestCI commented May 23, 2018

Automation for azure-sdk-for-ruby

Encountered a Subprocess error: (azure-sdk-for-ruby)

Command: ['/usr/local/bin/autorest', '/tmp/tmps0c5m31j/rest/specification/monitor/resource-manager/readme.md', '--multiapi', '--ruby', '--ruby-sdks-folder=/tmp/tmps0c5m31j/sdk', '--use=@microsoft.azure/autorest.ruby@3.0.20', '--version=preview']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4279/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4279)
   Loading AutoRest extension '@microsoft.azure/autorest.ruby' (3.0.20->3.0.20)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.1.22->2.1.22)
Processing batch task - {"tag":"package-2015-04-01-only"} .
Processing batch task - {"tag":"package-2016-03-01-only"} .
Processing batch task - {"tag":"package-2016-09-01-only"} .

ERROR (Fatal/DuplicateParameterCollision): Duplicated global non-identical parameter definitions
    - file:///tmp/tmps0c5m31j/rest/specification/monitor/resource-manager/microsoft.insights/stable/2016-09-01/serviceDiagnosticsSettings_API.json:395:4 ($.parameters.ResourceUriParameter)
    - file:///tmp/tmps0c5m31j/rest/specification/monitor/resource-manager/microsoft.insights/stable/2016-09-01/metrics_API.json:269:4 ($.parameters.ResourceUriParameter)
Process() cancelled due to exception : Cancellation requested.
Failure during batch task - {"tag":"package-2016-09-01-only"} -- Cancellation requested..
  Cancellation requested.

@AutorestCI
Copy link

AutorestCI commented May 23, 2018

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpab9gbj25/rest/specification/monitor/resource-manager/readme.md', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpab9gbj25/sdk', '--use=@microsoft.azure/autorest.python@~3.0', '--version=preview']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4279/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4279)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (~3.0->3.0.51)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)

ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
    - file:///tmp/tmpab9gbj25/rest/specification/monitor/resource-manager/microsoft.insights/stable/2018-04-16/scheduledQueryRule_API.json:255:4 ($.definitions.Resource)
    - file:///tmp/tmpab9gbj25/rest/specification/monitor/resource-manager/microsoft.insights/stable/2018-03-01/metricAlert_API.json:562:4 ($.definitions.Resource)
    - file:///tmp/tmpab9gbj25/rest/specification/monitor/resource-manager/microsoft.insights/stable/2017-04-01/activityLogAlerts_API.json:290:8 ($.definitions.Resource)
    - file:///tmp/tmpab9gbj25/rest/specification/monitor/resource-manager/microsoft.insights/stable/2018-03-01/actionGroups_API.json:338:8 ($.definitions.Resource)
    - file:///tmp/tmpab9gbj25/rest/specification/monitor/resource-manager/microsoft.insights/stable/2016-03-01/logProfiles_API.json:264:4 ($.definitions.Resource)
    - file:///tmp/tmpab9gbj25/rest/specification/monitor/resource-manager/microsoft.insights/stable/2016-03-01/alertRules_API.json:791:4 ($.definitions.Resource)
    - file:///tmp/tmpab9gbj25/rest/specification/monitor/resource-manager/microsoft.insights/stable/2015-04-01/autoscale_API.json:840:4 ($.definitions.Resource)

ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
    - file:///tmp/tmpab9gbj25/rest/specification/monitor/resource-manager/microsoft.insights/stable/2018-04-16/scheduledQueryRule_API.json:413:4 ($.definitions.MetricTrigger)
    - file:///tmp/tmpab9gbj25/rest/specification/monitor/resource-manager/microsoft.insights/stable/2015-04-01/autoscale_API.json:900:4 ($.definitions.MetricTrigger)
Process() cancelled due to exception : Cancellation requested.
  Cancellation requested.

@AutorestCI
Copy link

AutorestCI commented May 23, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1879

@dsgouda
Copy link
Contributor

dsgouda commented May 24, 2018

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants