Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Updates - description text #2998

Merged
merged 12 commits into from
May 3, 2018
Merged

Minor Updates - description text #2998

merged 12 commits into from
May 3, 2018

Conversation

abversqr
Copy link
Member

@abversqr abversqr commented May 2, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

abversqr added 11 commits April 12, 2018 16:43
@abversqr
Added GA API version for Scheduled Query Rule
2e4c790 
Added GA API version for Scheduled Query Rule
@abversqr
Resolving Comments
d183bad 
Resolving Comments
@abversqr
Made SKU as top level proprty and including generic error response fo…
df40ac3 
…rmat

Couple of changes -
1. Made SKU as top level proprty as mentioned here - https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/resource-api-reference.md#put-resource
 2. including generic error response format
@abversqr
Minor Changes to align implementation
7578160 
1. Removed SKU - Billing Model is still under discussion, hence need not to be exposed to customers.
2.  Enabled field ichanged to align with camel case.
3.  'throttleTillDate' in properties.action changed to 'throttlingInMin' to denote correct meaning  and it’s data type changed to number instead of date.
4. 'status' to be removed in properties.action from examples.
5.  'severity' made a required field in properties.action.
6. Removed Examples from original spec json
@abversqr
Updated Example to reflect AI instances in tags and 'dataSourceId"
c39fa0c 
Updated Example to reflect AI instances in tags and 'dataSourceId"
@abversqr
made 'tags' details more descriptive
5762ef5
@abversqr
Restore Tags Description
caabc1b 
Restore Tags Description
@abversqr
Fixed Exmaple Validation
ef75786 
Fixed errores reported by running command "oav validate-example"
@abversqr
Added Default Response payload in all APIs
fb180fb 
Changes -
1. Added Default Response payload in all APIs
2. Made azNs description more clear
@abversqr
Updating descriptions + property name change
6fb4ce9 
Updating descriptions + property name change
@abversqr
Merge pull request #1 from abversqr/MinorUpdates
0c82679 
Minor updates
@AutorestCI AutorestCI mentioned this pull request May 2, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented May 2, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2460

@azuresdkci azuresdkci requested a review from lmazuel May 2, 2018 07:55
@AutorestCI AutorestCI mentioned this pull request May 2, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented May 2, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2602

@AutorestCI AutorestCI mentioned this pull request May 2, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented May 2, 2018 •
edited
Loading

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#31

@AutorestCI AutorestCI mentioned this pull request May 2, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented May 2, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1774

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/monitor/resource-manager/readme.md

⚠️0 new Warnings.(17 total)
❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/monitor/resource-manager/readme.md

⚠️0 new Warnings.(20 total)
❌0 new Errors.(1 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@lmazuel
Copy link
Member

lmazuel commented May 3, 2018

Travis is red because of broken of Travis failure for Python (not even started our scripts), and linter failure not related to this PR (same file, but not same area). Merging.

@lmazuel lmazuel merged commit cc7cbd6 into Azure:master May 3, 2018
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
Merge pull request #2998 from Azure/rpaasmaster-servicelinker-uri-update
1fd0720 
Update servicelinker.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel lmazuel approved these changes

Assignees

@lmazuel lmazuel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abversqr @AutorestCI @azuresdkciprbot @lmazuel