Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add color classes to the editor styles #898

Merged
merged 2 commits into from
Apr 28, 2020
Merged

Add color classes to the editor styles #898

merged 2 commits into from
Apr 28, 2020

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Prior to Gutenberg 7.9, the editor styles didn't need the colour classes for the editor colour palette supplied by the theme, but now it does.

This PR adds those classes to the editor styles, and the custom colour files.

See #893.

How to test the changes in this Pull Request:

  1. Navigate to Customize > Colors, and pick the default palette.
  2. Copy-paste this test content into the editor: https://cloudup.com/cvdunVleCZF
  3. Note the appearance -- none of the custom colours are being picked up:

image

  1. Apply the PR and run npm run build.
  2. Confirm that the colours are being applied in the editor:

image

  1. Navigate to Customize > Colors, and pick a new primary and secondary colour.
  2. Return to the editor and confirm they're now being applied to the blocks marked 'primary' and 'secondary':

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added the [Status] Needs Review The issue or pull request needs to be reviewed label Apr 24, 2020
@laurelfulford
Copy link
Contributor Author

I'm not sure if this is a deliberate in Gutenberg, so I filed an issue here to check, just in case!

WordPress/gutenberg#21881

@laurelfulford
Copy link
Contributor Author

Looks like the above issue has been marked a bug in the Gutenberg repo, but it could still makes sense to patch it in the theme for now, so the experience isn't completely broken, and remove those styles later when it's fixed in Gutenberg.

@jeffersonrabb jeffersonrabb self-requested a review April 28, 2020 12:49
jeffersonrabb
jeffersonrabb approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@jeffersonrabb jeffersonrabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jeffersonrabb jeffersonrabb added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Apr 28, 2020
@laurelfulford
Copy link
Contributor Author

Thanks Jeff!

@laurelfulford laurelfulford merged commit 6e94411 into master Apr 28, 2020
@laurelfulford laurelfulford mentioned this pull request Apr 28, 2020
Closed
matticbot pushed a commit that referenced this pull request Apr 29, 2020
@semantic-release-bot
chore(release): 1.6.1 [skip ci]
ddbd421 
## [1.6.1](v1.6.0...v1.6.1) (2020-04-29)

### Bug Fixes

* add a temporary fix for a doubled block button outline ([#907](#907)) ([57df314](57df314))
* add color selectors for the editor ([#898](#898)) ([6e94411](6e94411))
* improve appearance of caption with beside featured image setting ([#882](#882)) ([1da6e44](1da6e44))
* make sure amp styles work with logo centering ([#887](#887)) ([0aaec4c](0aaec4c))
* make sure first floated element has top margin ([#903](#903)) ([733d482](733d482))
* tweak primary menu to be properly centred ([#884](#884)) ([9897cb1](9897cb1))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffersonrabb jeffersonrabb jeffersonrabb approved these changes

Assignees
No one assigned
Labels
Gutenberg 7.9 released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurelfulford @matticbot @jeffersonrabb