Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button Block: Add temporary fix for doubled-button outline #907

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Button Block: Add temporary fix for doubled-button outline #907

merged 1 commit into from
Apr 28, 2020

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Adds a temporary fix to a doubled-border issue in Gutenberg, and can be removed once the fix baked into Gutenberg in 8.0.

Closes #906.

How to test the changes in this Pull Request:

  1. Turn off the Gutenberg plugin.
  2. Add a button block with a few buttons and them the outline button style.
  3. View on the front end:

image

  1. Turn back on the Gutenberg plugin, and confirm it's at least version 7.9.
  2. Refresh the page with the buttons:

image

  1. Apply the PR and run npm run build.
  2. Confirm the buttons no longer have the doubled border.
  3. Turn back off the Gutenberg plugin.
  4. View the buttons again; confirm that the change won't have a negative impact on the buttons when not running 7.9.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added [Status] Needs Review The issue or pull request needs to be reviewed Smaller PR This PR is smaller and quick to test. Gutenberg 7.9 labels Apr 28, 2020
@jeffersonrabb jeffersonrabb self-requested a review April 28, 2020 19:39
jeffersonrabb
jeffersonrabb approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@jeffersonrabb jeffersonrabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Are you calling it temporary because of an expected resolution in Gutenberg?

@jeffersonrabb jeffersonrabb added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Apr 28, 2020
@laurelfulford
Copy link
Contributor Author

Thanks Jeff!

Are you calling it temporary because of an expected resolution in Gutenberg?

Yes! A fix is slated for Gutenberg 8.0; we should be able to remove it again once that's available.

@laurelfulford laurelfulford merged commit 57df314 into master Apr 28, 2020
@laurelfulford laurelfulford deleted the fixes/button-double-border branch April 28, 2020 19:43
matticbot pushed a commit that referenced this pull request Apr 29, 2020
@semantic-release-bot
chore(release): 1.6.1 [skip ci]
ddbd421 
## [1.6.1](v1.6.0...v1.6.1) (2020-04-29)

### Bug Fixes

* add a temporary fix for a doubled block button outline ([#907](#907)) ([57df314](57df314))
* add color selectors for the editor ([#898](#898)) ([6e94411](6e94411))
* improve appearance of caption with beside featured image setting ([#882](#882)) ([1da6e44](1da6e44))
* make sure amp styles work with logo centering ([#887](#887)) ([0aaec4c](0aaec4c))
* make sure first floated element has top margin ([#903](#903)) ([733d482](733d482))
* tweak primary menu to be properly centred ([#884](#884)) ([9897cb1](9897cb1))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffersonrabb jeffersonrabb jeffersonrabb approved these changes

Assignees
No one assigned
Labels
Gutenberg 7.9 released Smaller PR This PR is smaller and quick to test. [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button Block: Add temporary fix for double-outline in Gutenberg 7.9+
3 participants
@laurelfulford @matticbot @jeffersonrabb