Make sure amp styles work with logo centering #887
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
There is a weird case where AMP will add the following CSS to a site, and it will cause the centred logo not to work when they have a width, height and sizes attribute:
This PR adds some 'backup' CSS in this cases, so rather than relying on the
img
to bedisplay: inline-block
, it will also work when it's display block.How to test the changes in this Pull Request:
npm run build
.Other information: