Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Featured Image: improve appearance of caption with beside featured image setting #882

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Featured Image: improve appearance of caption with beside featured image setting #882

merged 1 commit into from
Apr 27, 2020

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

When the 'beside post title' option is selected for the featured image, this update moves the caption from below the featured image to overlaying the bottom of it.

This creates better connection between the featured image and the caption, as it doesn't run wider than the image, and sits directly on top of it.

Closes #880

How to test the changes in this Pull Request:

  1. Set up a post with a featured image; add a caption and select the 'beside post title' option.
  2. View on the front end and note the position:

image

  1. Apply the PR and run npm run build.
  2. Confirm that the caption placement is now on top of the featured image, and is legible:

image

  1. Size down the browser window; confirm that the caption moves below the featured image when it no longer sits next to the post title:

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added the [Status] Needs Review The issue or pull request needs to be reviewed label Apr 14, 2020
@jeffersonrabb jeffersonrabb added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Apr 27, 2020
@laurelfulford
Copy link
Contributor Author

Thanks!

@laurelfulford laurelfulford merged commit 1da6e44 into master Apr 27, 2020
@laurelfulford laurelfulford deleted the fixes/880-improved-caption-placement branch April 27, 2020 21:03
matticbot pushed a commit that referenced this pull request Apr 29, 2020
@semantic-release-bot
chore(release): 1.6.1 [skip ci]
ddbd421 
## [1.6.1](v1.6.0...v1.6.1) (2020-04-29)

### Bug Fixes

* add a temporary fix for a doubled block button outline ([#907](#907)) ([57df314](57df314))
* add color selectors for the editor ([#898](#898)) ([6e94411](6e94411))
* improve appearance of caption with beside featured image setting ([#882](#882)) ([1da6e44](1da6e44))
* make sure amp styles work with logo centering ([#887](#887)) ([0aaec4c](0aaec4c))
* make sure first floated element has top margin ([#903](#903)) ([733d482](733d482))
* tweak primary menu to be properly centred ([#884](#884)) ([9897cb1](9897cb1))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffersonrabb jeffersonrabb jeffersonrabb approved these changes

Assignees
No one assigned
Labels
released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Featured Image: Improve caption placement for 'beside' image placement
3 participants
@laurelfulford @matticbot @jeffersonrabb