Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme's editor palette colours not previewing in editor #21881

Closed
laurelfulford opened this issue Apr 24, 2020 · 1 comment
Closed

Theme's editor palette colours not previewing in editor #21881

laurelfulford opened this issue Apr 24, 2020 · 1 comment
Labels
Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended

Comments

@laurelfulford
Copy link
Contributor

Describe the bug
As of 7.9, it looks like the editor colours provided by the theme don't preview in the editor; they used to be added inline on the element, but now are not. Custom colours seem to work as expected.

I can reproduce this in Twenty Nineteen; Twenty Twenty includes its custom colours in the editor styles so it still works there; I thought it may be a change to move away from inline colours, but I couldn't find a related ticket; please close if that is the case, though!

To reproduce
Steps to reproduce the behavior:

  1. Start with a test site running Twenty Nineteen, and Gutenberg 7.9 or 7.9.1.
  2. Add a paragraph block to a page or post.
  3. Give the paragraph block a colour and a background colour, using the theme's colour palette.

Expected behavior
That the colours would be applied.

Screenshots
Note: it looks like the text is disappearing in Twenty Nineteen -- it's actually the white text colour coming from the theme when the background is set to a darker colour. It is applying the .has-background class, and the related padding, but no background colour.

twenty-nineteen-colors

image

Editor version (please complete the following information):

  • WordPress version: 5.4
  • Does the website has Gutenberg plugin installed, or is it using the block editor that comes by default? Gutenberg plugin
  • If the Gutenberg plugin is installed, which version is it? 7.9 and 7.9.1.

Desktop (please complete the following information):

  • OS: Mac OS
  • Browser Firefox
  • Version 75
@karmatosed karmatosed added the [Type] Bug An existing feature does not function as intended label Apr 27, 2020
@skorasaurus skorasaurus added the Needs Testing Needs further testing to be confirmed. label Jun 15, 2021
@skorasaurus
Copy link
Member

I'm not able to reproduce this on 11.2 Gutenberg.

If you're still able to reproduce this in the newest version of Gutenberg, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants