fix: request focus in find replace menu #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #440 +/- ##
==========================================
+ Coverage 79.91% 79.93% +0.01%
==========================================
Files 274 274
Lines 11454 11462 +8
==========================================
+ Hits 9154 9162 +8
Misses 2300 2300
☔ View full report in Codecov by Sentry. |
|
Closes #386 |
q200892907
added a commit
to q200892907/appflowy-editor
that referenced
this pull request
Sep 13, 2023
* main: chore: refactor attribute comparison in Delta class diff loop (AppFlowy-IO#456) fix: duration cannot be zero in animate (AppFlowy-IO#452) chore: update Chinese l10n (AppFlowy-IO#445) fix: sometimes failed to paste content from google translation (AppFlowy-IO#451) feat: refactor color conversion method to handle RGB and hex formatsRefactor method to handle RGB and hex formats, improving color conversion (AppFlowy-IO#450) fix: unable to paste html contains section (AppFlowy-IO#448) fix: remove unused check in non_delta_input_service (AppFlowy-IO#447) feat: optimize the performance (AppFlowy-IO#442) refactor: migrate tests (AppFlowy-IO#438) feat: bulk open links shortcut (AppFlowy-IO#419) fix: request focus in find replace menu (AppFlowy-IO#440) feat: implement delta diff and provide external values (AppFlowy-IO#444)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a workaround to keep focus after submitting in the find/replace text fields, otherwise the focus is forced on the editor due to the interactions required.