Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor color conversion method to handle RGB and hex formatsRefactor method to handle RGB and hex formats, improving color conversion #450

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Sep 12, 2023

Support some color formats.

  • rgb
  • rgba
  • 0x(6-8)
  • #(6)

…efactor method to handle RGB and hex formats, improving color conversion
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 94.11% and no project coverage change.

Comparison is base (82c1cf2) 80.53% compared to head (56df582) 80.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #450   +/-   ##
=======================================
  Coverage   80.53%   80.53%           
=======================================
  Files         280      280           
  Lines       11300    11304    +4     
=======================================
+ Hits         9100     9104    +4     
  Misses       2200     2200           
Files Changed Coverage Δ
...mponent/base_component/background_color_mixin.dart 66.66% <0.00%> (ø)
...itor/toolbar/desktop/items/color/color_picker.dart 67.96% <0.00%> (ø)
.../block_component/rich_text/appflowy_rich_text.dart 91.39% <100.00%> (ø)
...le_block_component/table_cell_block_component.dart 92.30% <100.00%> (ø)
...mobile/toolbar_items/color/utils/color_button.dart 100.00% <100.00%> (ø)
lib/src/editor/util/color_util.dart 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 12be127 into AppFlowy-IO:main Sep 12, 2023
9 of 10 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Sep 13, 2023
* main:
  chore: refactor attribute comparison in Delta class diff loop (AppFlowy-IO#456)
  fix: duration cannot be zero in animate (AppFlowy-IO#452)
  chore: update Chinese l10n (AppFlowy-IO#445)
  fix: sometimes failed to paste content from google translation (AppFlowy-IO#451)
  feat: refactor color conversion method to handle RGB and hex formatsRefactor method to handle RGB and hex formats, improving color conversion (AppFlowy-IO#450)
  fix: unable to paste html contains section (AppFlowy-IO#448)
  fix: remove unused check in non_delta_input_service (AppFlowy-IO#447)
  feat: optimize the performance (AppFlowy-IO#442)
  refactor: migrate tests (AppFlowy-IO#438)
  feat: bulk open links shortcut (AppFlowy-IO#419)
  fix: request focus in find replace menu (AppFlowy-IO#440)
  feat: implement delta diff and provide external values (AppFlowy-IO#444)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant