Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement delta diff and provide external values #444

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Sep 11, 2023

  • Provide ExternalValues to save the external values that are not defined in the node.
  • Implement Delta Diff

@LucasXu0 LucasXu0 changed the title Delta diff feat: implement delta diff and provide external values Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 91.22% and project coverage change: +0.03% 🎉

Comparison is base (3f2db9b) 79.91% compared to head (31fd75a) 79.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
+ Coverage   79.91%   79.95%   +0.03%     
==========================================
  Files         274      274              
  Lines       11454    11501      +47     
==========================================
+ Hits         9154     9196      +42     
- Misses       2300     2305       +5     
Files Changed Coverage Δ
lib/src/core/document/node.dart 77.27% <50.00%> (-0.42%) ⬇️
lib/src/core/document/text_delta.dart 97.61% <92.72%> (-1.18%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit dd59eb5 into AppFlowy-IO:main Sep 11, 2023
10 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Sep 13, 2023
* main:
  chore: refactor attribute comparison in Delta class diff loop (AppFlowy-IO#456)
  fix: duration cannot be zero in animate (AppFlowy-IO#452)
  chore: update Chinese l10n (AppFlowy-IO#445)
  fix: sometimes failed to paste content from google translation (AppFlowy-IO#451)
  feat: refactor color conversion method to handle RGB and hex formatsRefactor method to handle RGB and hex formats, improving color conversion (AppFlowy-IO#450)
  fix: unable to paste html contains section (AppFlowy-IO#448)
  fix: remove unused check in non_delta_input_service (AppFlowy-IO#447)
  feat: optimize the performance (AppFlowy-IO#442)
  refactor: migrate tests (AppFlowy-IO#438)
  feat: bulk open links shortcut (AppFlowy-IO#419)
  fix: request focus in find replace menu (AppFlowy-IO#440)
  feat: implement delta diff and provide external values (AppFlowy-IO#444)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant