Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Confusing UX on Replace Dialog after pressing Enter key #386

Closed
MayurSMahajan opened this issue Aug 14, 2023 · 2 comments
Closed

[Bug] Confusing UX on Replace Dialog after pressing Enter key #386

MayurSMahajan opened this issue Aug 14, 2023 · 2 comments
Assignees

Comments

@MayurSMahajan
Copy link
Contributor

Bug Description

While replacing a word with Replace Dialog in the AppFlowy Editor,
we are able to replace the first match by pressing Enter key
But then the focus shifts into the Editor and now pressing the Enter key inserts a newline character instead of replacing the next match.

How to Reproduce

  1. Open AppFlowy Editor
  2. Open Replace Dialog
  3. Enter a find string and a replace string.
  4. Now focusing on the Replace string press Enter
  5. Now press enter again.

Expected Behavior

Two behaviors can be expected:

  1. The next matched word should be replaced.
  2. It should not be possible to replace any match with Enter key in first place

Operating System

Windows 11

AppFlowy Editor Version(s)

1.2.3

Screenshots

replace_ux

Additional Context

No response

@MayurSMahajan
Copy link
Contributor Author

@LucasXu0 @Xazin
Guys, which behavior should we expect? I am leaning towards 1.
Also assign this issue to me.

@Xazin
Copy link
Collaborator

Xazin commented Aug 14, 2023

The problem here is the editor receives focus and thus the enter is not registered from the find dialog.

Resolve that and it will be fine I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants